Use allowlist_externals instead of whitelist_externals #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tox's whitelist_externals has been removed in favour of
allowlist_externals, which led to `rm` not being considered
part of the allow-list, and the tests failing with:
rm is not allowed, use allowlist_externals to allow it
We already had the right commands in the allow-list, but we
were just using the wrong variable name in tox.ini.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tox's whitelist_externals has been removed in favour of allowlist_externals, which led to
rmnot being considered part of the allow-list, and the tests failing with:We already had the right commands in the allow-list, but we were just using the wrong variable name in tox.ini.