Bump Python requirement to 3.8 and replace usage of pkg_resources #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, LNT would use the pkg_resources package to extract metadata about the current installation. However, that package has been deprecated in recent Python versions, which produces a warning. Fixing this either requires switching to the recommended alternative, or pinning the setuptools dependency to a version < 81. This patch switches to the recommended alternative (importlib.metadata) and bumps the Python requirement to 3.8, which is when importlib.metadata was introduced. This version bump is fairly gentle and makes us match the Python requirement used by the rest of LLVM (which is IMO overdue for a bump as well), so I think it's reasonable.
jroelofs
approved these changes
Oct 3, 2025
|
Note that the reason I started looking into this issue is that the |
lukel97
added a commit
that referenced
this pull request
Oct 6, 2025
To help get the ball rolling with deploying LNT, this adds a GitHub action to build and push images to the GitHub container registry, which is free for public repos. This will push a new image to ghcr.io/llvm-project/llvm-lnt:latest whenever anything is pushed to the main branch. It also includes a fix for the Dockerfile after the minimum python version was bumped to 3.8 in #48. 3.10 is as high as we can go before we need to upgrade psycopg to 3.x, which in turn requires upgrading sqlalchemy to god knows what. We also need to upgrade psycopg 2.x anyway to get it to build with the newer python bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, LNT would use the pkg_resources package to extract metadata about the current installation. However, that package has been deprecated in recent Python versions, which produces a warning. Fixing this either requires switching to the recommended alternative, or pinning the setuptools dependency to a version < 81.
This patch switches to the recommended alternative (importlib.metadata) and bumps the Python requirement to 3.8, which is when importlib.metadata was introduced.
This version bump is fairly gentle and makes us match the Python requirement used by the rest of LLVM (which is IMO overdue for a bump as well), so I think it's reasonable.