Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Build Docker image

on:
push:
branches: ['main']

jobs:
build:
runs-on: ubuntu-latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin this to ubuntu-24.04. We've run into quite a few unexpected breakages due to the ubuntu version bumping on us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in cd731d0


permissions:
contents: read

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contents: read should be a top level permission. See https://llvm.org/docs/CIBestPractices.html.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 9992e48

packages: write
id-token: write

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? We do not use in the workflows in the monorepo https://github.com/llvm/llvm-project/blob/main/.github/workflows/build-ci-container.yml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 7d7e489


steps:
- uses: actions/checkout@v5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these actions need to be hash pinned. See https://llvm.org/docs/CIBestPractices.html.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 7ba9006

- name: Log in to the Container registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Build and push Docker image
id: push
uses: docker/build-push-action@v6
with:
context: docker
push: true
tags: ghcr.io/${{github.repository}}:latest
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.7-alpine
FROM python:3.10-alpine

RUN apk update \
&& apk add --no-cache --virtual .build-deps git g++ postgresql-dev yaml-dev \
Expand Down
2 changes: 1 addition & 1 deletion requirements.server.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# These requirements are what you would install on a production server.
.
psycopg2==2.8
psycopg2==2.9.10
gunicorn==19.9.0
progressbar2
Loading