Add a temporary Lit feature to XFAIL tests that are currently failing #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldionne
force-pushed
the
review/temporary-xfails
branch
from
6008360 to
b443954
Compare
Sorry, I was trying to get the CI working. I'll rebase and mark this as ready soon. |
This will allow the CI to report everything as green as we work on making all the tests green. I also renamed a CHECK-<prefix> directive in test_suite-c-compiler.shtest because it was conflicting with the recent `DEFINE:` lit directive, making the test fail as UNRESOLVED.
ldionne
force-pushed
the
review/temporary-xfails
branch
from
b443954 to
ef9a1e7
Compare
|
This is ready for review. The CI is now all passing with Python 3.10. |
boomanaiden154
approved these changes
Oct 6, 2025
The CI isn't passing because we still run Python 3.9. But if you look at the Python 3.10 job, you'll see that everything "passed" and then the job was cancelled (due to the Python 3.9 failure). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the CI to report everything as green as we work on making all the tests green. I also renamed a CHECK- directive in test_suite-c-compiler.shtest because it was conflicting with the recent
DEFINE:lit directive, making the test fail as UNRESOLVED.