Skip to content

Commit c65627a

Browse files
committed
Revert "[lldb] Don't send invalid region addresses to lldb server"
This reverts commit c687af0 due to a test failure on Windows.
1 parent fece148 commit c65627a

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

lldb/source/Commands/CommandObjectMemory.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1707,7 +1707,6 @@ class CommandObjectMemoryRegion : public CommandObjectParsed {
17071707
"invalid address argument \"%s\": %s\n", command[0].c_str(),
17081708
error.AsCString());
17091709
result.SetStatus(eReturnStatusFailed);
1710-
return false;
17111710
}
17121711
}
17131712

lldb/test/API/functionalities/memory-region/TestMemoryRegion.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,6 @@ def test(self):
4141
self.assertFalse(result.Succeeded())
4242
self.assertRegexpMatches(result.GetError(), "Usage: memory region ADDR")
4343

44-
# Test that when the address fails to parse, we show an error and do not continue
45-
interp.HandleCommand("memory region not_an_address", result)
46-
self.assertFalse(result.Succeeded())
47-
self.assertEqual(result.GetError(),
48-
"error: invalid address argument \"not_an_address\": address expression \"not_an_address\" evaluation failed\n")
49-
5044
# Now let's print the memory region starting at 0 which should always work.
5145
interp.HandleCommand("memory region 0x0", result)
5246
self.assertTrue(result.Succeeded())

0 commit comments

Comments
 (0)