Skip to content

Commit cd11a7f

Browse files
[NewPM] Remove LoopInstSimplifyLegacyPass (#72812)
This pass isn't used anywhere and thus has no test coverage. Remove it for these reasons. For whatever reason, there was no entry in `llvm/include/llvm/LinkAllPasses.h` to remove.
1 parent b9975ce commit cd11a7f

File tree

4 files changed

+0
-65
lines changed

4 files changed

+0
-65
lines changed

llvm/include/llvm/InitializePasses.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,6 @@ void initializeLoopDataPrefetchLegacyPassPass(PassRegistry&);
175175
void initializeLoopExtractorLegacyPassPass(PassRegistry &);
176176
void initializeLoopGuardWideningLegacyPassPass(PassRegistry&);
177177
void initializeLoopInfoWrapperPassPass(PassRegistry&);
178-
void initializeLoopInstSimplifyLegacyPassPass(PassRegistry&);
179178
void initializeLoopPassPass(PassRegistry&);
180179
void initializeLoopPredicationLegacyPassPass(PassRegistry&);
181180
void initializeLoopRotateLegacyPassPass(PassRegistry&);

llvm/include/llvm/Transforms/Scalar.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,6 @@ Pass *createLoopPredicationPass();
7474
//
7575
Pass *createLoopStrengthReducePass();
7676

77-
//===----------------------------------------------------------------------===//
78-
//
79-
// LoopInstSimplify - This pass simplifies instructions in a loop's body.
80-
//
81-
Pass *createLoopInstSimplifyPass();
82-
8377
//===----------------------------------------------------------------------===//
8478
//
8579
// LoopUnroll - This pass is a simple loop unrolling pass.

llvm/lib/Transforms/Scalar/LoopInstSimplify.cpp

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@
2929
#include "llvm/IR/Instructions.h"
3030
#include "llvm/IR/Module.h"
3131
#include "llvm/IR/PassManager.h"
32-
#include "llvm/InitializePasses.h"
33-
#include "llvm/Pass.h"
3432
#include "llvm/Support/Casting.h"
3533
#include "llvm/Transforms/Scalar.h"
3634
#include "llvm/Transforms/Utils/Local.h"
@@ -172,46 +170,6 @@ static bool simplifyLoopInst(Loop &L, DominatorTree &DT, LoopInfo &LI,
172170
return Changed;
173171
}
174172

175-
namespace {
176-
177-
class LoopInstSimplifyLegacyPass : public LoopPass {
178-
public:
179-
static char ID; // Pass ID, replacement for typeid
180-
181-
LoopInstSimplifyLegacyPass() : LoopPass(ID) {
182-
initializeLoopInstSimplifyLegacyPassPass(*PassRegistry::getPassRegistry());
183-
}
184-
185-
bool runOnLoop(Loop *L, LPPassManager &LPM) override {
186-
if (skipLoop(L))
187-
return false;
188-
DominatorTree &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
189-
LoopInfo &LI = getAnalysis<LoopInfoWrapperPass>().getLoopInfo();
190-
AssumptionCache &AC =
191-
getAnalysis<AssumptionCacheTracker>().getAssumptionCache(
192-
*L->getHeader()->getParent());
193-
const TargetLibraryInfo &TLI =
194-
getAnalysis<TargetLibraryInfoWrapperPass>().getTLI(
195-
*L->getHeader()->getParent());
196-
MemorySSA *MSSA = &getAnalysis<MemorySSAWrapperPass>().getMSSA();
197-
MemorySSAUpdater MSSAU(MSSA);
198-
199-
return simplifyLoopInst(*L, DT, LI, AC, TLI, &MSSAU);
200-
}
201-
202-
void getAnalysisUsage(AnalysisUsage &AU) const override {
203-
AU.addRequired<AssumptionCacheTracker>();
204-
AU.addRequired<DominatorTreeWrapperPass>();
205-
AU.addRequired<TargetLibraryInfoWrapperPass>();
206-
AU.setPreservesCFG();
207-
AU.addRequired<MemorySSAWrapperPass>();
208-
AU.addPreserved<MemorySSAWrapperPass>();
209-
getLoopAnalysisUsage(AU);
210-
}
211-
};
212-
213-
} // end anonymous namespace
214-
215173
PreservedAnalyses LoopInstSimplifyPass::run(Loop &L, LoopAnalysisManager &AM,
216174
LoopStandardAnalysisResults &AR,
217175
LPMUpdater &) {
@@ -231,18 +189,3 @@ PreservedAnalyses LoopInstSimplifyPass::run(Loop &L, LoopAnalysisManager &AM,
231189
PA.preserve<MemorySSAAnalysis>();
232190
return PA;
233191
}
234-
235-
char LoopInstSimplifyLegacyPass::ID = 0;
236-
237-
INITIALIZE_PASS_BEGIN(LoopInstSimplifyLegacyPass, "loop-instsimplify",
238-
"Simplify instructions in loops", false, false)
239-
INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker)
240-
INITIALIZE_PASS_DEPENDENCY(LoopPass)
241-
INITIALIZE_PASS_DEPENDENCY(MemorySSAWrapperPass)
242-
INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
243-
INITIALIZE_PASS_END(LoopInstSimplifyLegacyPass, "loop-instsimplify",
244-
"Simplify instructions in loops", false, false)
245-
246-
Pass *llvm::createLoopInstSimplifyPass() {
247-
return new LoopInstSimplifyLegacyPass();
248-
}

llvm/lib/Transforms/Scalar/Scalar.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ void llvm::initializeScalarOpts(PassRegistry &Registry) {
3232
initializeInstSimplifyLegacyPassPass(Registry);
3333
initializeLegacyLICMPassPass(Registry);
3434
initializeLoopDataPrefetchLegacyPassPass(Registry);
35-
initializeLoopInstSimplifyLegacyPassPass(Registry);
3635
initializeLoopPredicationLegacyPassPass(Registry);
3736
initializeLoopRotateLegacyPassPass(Registry);
3837
initializeLoopStrengthReducePass(Registry);

0 commit comments

Comments
 (0)