[mlir][polly][llvm-lit] External shell unable to be turned on for lit tests

[connieyzhu]

In both mlir and polly, tests are run with lit's internal shell by default. In order to use the external shell instead, the LIT_USE_INTERNAL_SHELL environment variable should be set to 0. The logic in the lit configs of these test suites prevents the external shell from being turned on.

Code:

use_lit_shell = True
lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
if lit_shell_env:
	use_lit_shell = not lit.util.pythonize_bool(lit_shell_env)

config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell)

The problem lies in the body of the if statement, with the use of not.

[llvmbot]

@llvm/issue-subscribers-polly

Author: Connie Zhu (connieyzhu)

In both mlir and polly, tests are run with lit's internal shell by default. In order to use the external shell instead, the `LIT_USE_INTERNAL_SHELL` environment variable should be set to 0. The logic in the lit configs of these test suites prevents the external shell from being turned on.

Code:

use_lit_shell = True
lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
if lit_shell_env:
	use_lit_shell = not lit.util.pythonize_bool(lit_shell_env)

config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell)

The problem lies in the body of the if statement, with the use of not.