Sema::ActOnAsmStmt() is called before template instantiation

[llvmbot]

Bugzilla Link	10864
Resolution	FIXED
Resolved on	Sep 14, 2011 14:20
Version	trunk
OS	All
Attachments	An example showing inline assembly and CRTP usage.
Reporter	LLVM Bugzilla Contributor
CC	@DougGregor,@efriedma-quic

Extended Description

Sema::ActOnAsmStmt() performs type checking on the inline assembly. It is currently called when the templated class method is declared, not when the template class is instantiated, causing problem with Curiously Recurring Template Pattern usage because it is not able to reduce dependent type.

liulk

[DougGregor]

This is actually manifesting as an assertion failure for me (Assertion failed: (0 && "Unknown builtin type!"), function getTypeInfo, file /Volumes/Data/dgregor/Projects/llvm/tools/clang/lib/AST/ASTContext.cpp, line 852).

[llvmbot]

ActOnAsmStmt omits checking dependent type
Oh, sorry, I forgot to mention that I turned off all assertions and built llvm-clang as release.

If your stack trace shows that ASTContext::getTypeSize() is called by SemaStmt.cpp line 2159, then we're indeed looking at the same issue.

The proposed patch skips the type checking portion of ActOnAsmStmt() if either OutputExpr or InputExpr is type dependent. I hope that when the template is instantiated, ActOnAsmStmt() will be called again with instantiated type, but I don't know clang well enough to tell if that's the case.

liulk

[efriedma-quic]

r139716.