Skip to content

[lldb-dap] TestDAP_evaluate.py test is flakey #116041

Closed
@Michael137

Description

@Michael137

This has been failing occasionally on Linux during PR testing. E.g., most recently in #115517: https://buildkite.com/llvm-project/github-pull-requests/builds/118902#0193226e-5c0a-42ad-93ad-a29d91edbe26

Example failure:

FAIL: LLDB (/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/build/bin/clang-x86_64) :: test_repl_evaluate_expressions (TestDAP_evaluate.TestDAP_evaluate)
FAIL: LLDB (/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/build/bin/clang-x86_64) :: test_repl_evaluate_expressions (TestDAP_evaluate.TestDAP_evaluate)
PASS: LLDB (/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/build/bin/clang-x86_64) :: test_variable_evaluate_expressions (TestDAP_evaluate.TestDAP_evaluate)
PASS: LLDB (/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/build/bin/clang-x86_64) :: test_watch_evaluate_expressions (TestDAP_evaluate.TestDAP_evaluate)
======================================================================
ERROR: test_repl_evaluate_expressions (TestDAP_evaluate.TestDAP_evaluate)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/test/API/tools/lldb-dap/evaluate/TestDAP_evaluate.py", line 220, in test_repl_evaluate_expressions
    self.run_test_evaluate_expressions("repl", enableAutoVariableSummaries=False)
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/test/API/tools/lldb-dap/evaluate/TestDAP_evaluate.py", line 104, in run_test_evaluate_expressions
    self.assertEvaluate("var", r"\(lldb\) var\n.*")
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/test/API/tools/lldb-dap/evaluate/TestDAP_evaluate.py", line 17, in assertEvaluate
    self.dap_server.request_evaluate(expression, context=self.context)["body"][
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 721, in request_evaluate
    return self.send_recv(command_dict)
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 326, in send_recv
    raise ValueError(desc)
ValueError: no response for "evaluate"
Config=x86_64-/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/build/bin/clang
======================================================================
ERROR: test_repl_evaluate_expressions (TestDAP_evaluate.TestDAP_evaluate)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2030, in tearDown
    Base.tearDown(self)
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1100, in tearDown
    hook()  # try the plain call and hope it works
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py", line 401, in cleanup
    self.dap_server.request_disconnect(terminateDebuggee=True)
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 674, in request_disconnect
    return self.send_recv(command_dict)
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 320, in send_recv
    self.send_packet(command)
  File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py", line 275, in send_packet
    self.send.flush()
BrokenPipeError: [Errno 32] Broken pipe
Config=x86_64-/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-chnxh-1/llvm-project/github-pull-requests/build/bin/clang
----------------------------------------------------------------------
Ran 5 tests in 884.999s

The last couple of failures I looked at all fail when running self.assertEvaluate("var", r"\(lldb\) var\n.*").

Just going off of the git log CCing @ashgti @walter-erquinigo. Mind taking a look? We really don't want to be flakey on the pre-commit CI

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions