Skip to content

[PAC][libunwind] Refactor way of describing internal signing schemas #160101

@kovdan01

Description

@kovdan01

#143230 introduces many macros for internal signing schemas. Let's adopt @atrosinenko 's approach to make the code more readable. See original comment from the PR below.


(As an illustration for the "cover letter" of this review) I assume many such macroses define purely internal signing schemas. In such cases it should be possible to compute the discriminator automatically - it could probably improve readability to use something like

    PTRAUTH_INTPTR(uintptr_t, start) = readEncodedPointer(&p, callSiteEncoding);

instead of

    uintptr_t __ptrauth_gcc_personality_start start =
        readEncodedPointer(&p, callSiteEncoding);

Originally posted by @atrosinenko in #143230 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    hardeningIssues related to the hardening effortlibunwind

    Type

    No type

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions