clang-format 21 regression involving pointer arrow operator

[JohnC32]

Running clang-format 21.1.1 on the following which was indented using clang-format 19:

const char* Element::getName(std::size_t eIdx) {
    return (getStructType()->getElements())[eIdx]->getName();
}

using _clang-format:

---
BasedOnStyle: Google
IndentWidth: 4
...

results in the incorrect addition of spaces around the pointer arrow operator " -> ":

const char* Element::getName(std::size_t eIdx) {
    return (getStructType()->getElements())[eIdx] -> getName();
}

clang-format 19 does not add the whitespace around the pointer arrow operator.

Note, I'm upgrading from clang-format 19 to 21 and I did not try 20, so not sure when the behavior regressed.

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: John Ciolfi (JohnC32)

Running clang-format 21.1.1 on the following which was indented using clang-format 19:

const char* Element::getName(std::size_t eIdx) {
    return (getStructType()->getElements())[eIdx]->getName();
}

using _clang-format:

---
BasedOnStyle: Google
IndentWidth: 4
ColumnLimit: 100
AlignConsecutiveDeclarations: Consecutive
...

results in the incorrect addition of spaces around the pointer arrow operator " -> ":

const char* Element::getName(std::size_t eIdx) {
    return (getStructType()->getElements())[eIdx] -> getName();
}

clang-format 19 does not add the whitespace around the pointer arrow operator.

Note, I'm upgrading from clang-format 19 to 21 and I did not try 20, so not sure when the behavior regressed.

[owenca]

/cherry-pick 4edda3d

[llvmbot]

Failed to cherry-pick: 4edda3d

https://github.com/llvm/llvm-project/actions/runs/18069512274

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request