warning on return value in void function should be on by default

[llvmbot]

Bugzilla Link	2790
Resolution	FIXED
Resolved on	Mar 12, 2010 00:57
Version	unspecified
OS	Windows XP
Reporter	LLVM Bugzilla Contributor

Extended Description

clang misses a warning on:

void f2(int x) {
return x;
}

[llvmbot]

Works for me.

$ cat test.c
void f2(int x) {
return x;
}
$ clang -pedantic test.c
test.c:2:3: warning: void function 'f2' should not return a value
return x;
^ ~
1 diagnostic generated.

However, shouldn't it be on by default?

[llvmbot]

I added tests for current behaviour as test/Sema/function-return.c.

[llvmbot]

Ah, good catch. It seems to me it should always be on, we should check why it was originally written this way, however.

[lattner]

Fixed:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20081215/010327.html