linking of alias symbol with weak symbol fails

[llvmbot]

Bugzilla Link	2883
Resolution	FIXED
Resolved on	Nov 07, 2018 00:22
Version	trunk
OS	Linux
Reporter	LLVM Bugzilla Contributor
CC	@asl

Extended Description

Given a.ll

define weak void @​foo() {
ret void
}

and b.ll

@​foo = alias void ()* @​fooreal
define void @​fooreal() {
}

then linking a.ll with b.ll succeeds, but linking b.ll with
a.ll fails:

ddunbar@bohr:/foo$ llvm-as -f a.ll && llvm-as -f b.ll && llvm-link -f -o c.bc a.bc b.bc
ddunbar@bohr:/foo$ llvm-as -f a.ll && llvm-as -f b.ll && llvm-link -f -o c.bc b.bc a.bc
llvm-link: link error in 'a.bc': Function-Alias Collision on 'foo': symbol multiple defined
ddunbar@bohr:~/foo$

[llvmbot]

Possibly just a matter of changing LinkModules:988 from

if (!SF->isDeclaration())

to

if (!SF->isDeclaration() && !SF->mayBeOverridden())

?

[asl]

Possibly just a matter of changing LinkModules:988 from
Yes, you're right. Somehow comment was correct, but not code :)

Fixed in:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20081013/068529.html

also, same problem was fixed for global variables

[llvmbot]

Great, thanks Anton. Can this make 2.4?

[asl]

Great, thanks Anton. Can this make 2.4?
Ask Tanya, not me :)