Extend IndentPPDirectives with a BeforeHash option

[aardappel]

Bugzilla Link	36019
Version	trunk
OS	All
CC	@hartwork
Fixed by commit(s)	rL356613

Extended Description

Currently IndentPPDirectives can have values None:

#ifdef FOO
#define BAR
#endif

or AfterHash:

#ifdef FOO
#    define BAR
#endif

I am suggesting to also add BeforeHash:

#ifdef FOO
    #define BAR
#endif

[aardappel]

This is a follow-up from bug: #17736

[llvmbot]

I also think the BeforeHash option described by Wouter is needed. Thank you.

+1

[llvmbot]

I am working on BeforeHash as an option to IndentPPDirectives.

[hartwork]

judging from https://clang.llvm.org/docs/ClangFormatStyleOptions.html this feature is available in clang-format by now.

[llvmbot]

I was duped by the documentation as well, but the option does not seem to be present yet, and using it will break your .clang-format and therefore clang-format, probably silently.

[aardappel]

related bug: llvm/llvm-bugzilla-archive#39280

[aardappel]

mentioned in issue llvm/llvm-bugzilla-archive#36020

[aardappel]

mentioned in issue llvm/llvm-bugzilla-archive#36020

[llvmbot]

mentioned in issue llvm/llvm-bugzilla-archive#39163

[aardappel]

mentioned in issue llvm/llvm-bugzilla-archive#39280

[mkurdej]

Closing as the option is already present since clang-format 9 (whereas clang-format 6 had only None and AfterHash). Please create another issue if you consider that the behaviour is faulty.