callee can't get the i64 parameter correctly.

[llvmbot]

Bugzilla Link	3199
Resolution	INVALID
Resolved on	Jul 29, 2010 17:56
Version	unspecified
OS	MacOS X
Reporter	LLVM Bugzilla Contributor

Extended Description

when passing long long parameter mixed with short, int, (parameters should large than 8, so to run out of r3~r10), callee can't calculate the address of long long parameter passed by caller correctly(the alignment error, 4 bytes alignment should be added between long long's previous slot, not between long long's hi32 and lo32 slot).

[llvmbot]

What target? x86? Test case please with more detailed explanation please.

[llvmbot]

r3-r10 implies PPC. Codegen appears to be identical to gcc in the case I think he's talking about, so possible I don't understand. There are no alignment spaces for long long in this calling convention.

[llvmbot]

I have attached the IR, don't you received it?
I leave the assembly code on the url: http://pastebin.com/m7ad2eb65
I compiled the .bc with command line:
llc -f -march=ppc32 Para11Local5.bc -o Para11Local5.s

; ModuleID = 'Debug/Para11Local5.bc'
target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:32:32"
target triple = "i386-pc-linux-gnu"
@.str = internal constant [16 x i8] c"Test: sum = %d\0A\00" ; <[16 x i8]> [#uses=1]
@.str1 = internal constant [14 x i8] c"Test: i = %d\0A\00" ; <[14 x i8]> [#uses=1]
@.str2 = internal constant [14 x i8] c"Test: v = %d\0A\00" ; <[14 x i8]> [#uses=1]
@.str3 = internal constant [16 x i8] c"Test: x = %lld\0A\00" ; <[16 x i8]> [#uses=1]
@.str4 = internal constant [14 x i8] c"Test: z = %d\0A\00" ; <[14 x i8]*> [#uses=1]

define i32 @​func2(i32 %a, i32 %b, i32 %h) nounwind {
entry:
%a_addr = alloca i32 ; <i32*> [#uses=2]
%b_addr = alloca i32 ; <i32*> [#uses=2]
%h_addr = alloca i32 ; <i32*> [#uses=2]
%retval = alloca i32 ; <i32*> [#uses=2]
%0 = alloca i32 ; <i32*> [#uses=2]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
store i32 %a, i32* %a_addr
store i32 %b, i32* %b_addr
store i32 %h, i32* %h_addr
%1 = load i32* %a_addr, align 4 ; [#uses=1]
%2 = load i32* %b_addr, align 4 ; [#uses=1]
%3 = add i32 %1, %2 ; [#uses=1]
%4 = load i32* %h_addr, align 4 ; [#uses=1]
%5 = add i32 %3, %4 ; [#uses=1]
store i32 %5, i32* %0, align 4
%6 = load i32* %0, align 4 ; [#uses=1]
store i32 %6, i32* %retval, align 4
br label %return

return: ; preds = %entry
%retval1 = load i32* %retval ; [#uses=1]
ret i32 %retval1
}

define i32 @​func(i32 %a, i32 %b, i32 %c, i32 %d, i32 %e, i32 %f, i32 %g, i32 %h, i16 signext %v, i64 %x, i8 signext %z) nounwind {
entry:
%a_addr = alloca i32 ; <i32*> [#uses=4]
%b_addr = alloca i32 ; <i32*> [#uses=4]
%c_addr = alloca i32 ; <i32*> [#uses=2]
%d_addr = alloca i32 ; <i32*> [#uses=2]
%e_addr = alloca i32 ; <i32*> [#uses=2]
%f_addr = alloca i32 ; <i32*> [#uses=2]
%g_addr = alloca i32 ; <i32*> [#uses=2]
%h_addr = alloca i32 ; <i32*> [#uses=3]
%v_addr = alloca i16 ; <i16*> [#uses=2]
%x_addr = alloca i64 ; <i64*> [#uses=2]
%z_addr = alloca i8 ; <i8*> [#uses=2]
%retval = alloca i32 ; <i32*> [#uses=2]
%sum = alloca i32 ; <i32*> [#uses=3]
%l = alloca i32 ; <i32*> [#uses=2]
%k = alloca i32 ; <i32*> [#uses=1]
%j = alloca i32 ; <i32*> [#uses=2]
%i = alloca i32 ; <i32*> [#uses=3]
%0 = alloca i32 ; <i32*> [#uses=2]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
store i32 %a, i32* %a_addr
store i32 %b, i32* %b_addr
store i32 %c, i32* %c_addr
store i32 %d, i32* %d_addr
store i32 %e, i32* %e_addr
store i32 %f, i32* %f_addr
store i32 %g, i32* %g_addr
store i32 %h, i32* %h_addr
store i16 %v, i16* %v_addr
store i64 %x, i64* %x_addr
store i8 %z, i8* %z_addr
%1 = load i32* %a_addr, align 4 ; [#uses=1]
%2 = load i32* %b_addr, align 4 ; [#uses=1]
%3 = add i32 %1, %2 ; [#uses=1]
%4 = load i32* %c_addr, align 4 ; [#uses=1]
%5 = add i32 %3, %4 ; [#uses=1]
%6 = load i32* %d_addr, align 4 ; [#uses=1]
%7 = add i32 %5, %6 ; [#uses=1]
%8 = load i32* %e_addr, align 4 ; [#uses=1]
%9 = add i32 %7, %8 ; [#uses=1]
%10 = load i32* %f_addr, align 4 ; [#uses=1]
%11 = add i32 %9, %10 ; [#uses=1]
%12 = load i32* %g_addr, align 4 ; [#uses=1]
%13 = add i32 %11, %12 ; [#uses=1]
%14 = load i32* %h_addr, align 4 ; [#uses=1]
%15 = add i32 %13, %14 ; [#uses=1]
store i32 %15, i32* %i, align 4
%16 = load i32* %i, align 4 ; [#uses=1]
%17 = load i32* %a_addr, align 4 ; [#uses=1]
%18 = add i32 %16, %17 ; [#uses=1]
store i32 %18, i32* %j, align 4
%19 = load i32* %j, align 4 ; [#uses=1]
%20 = load i32* %b_addr, align 4 ; [#uses=1]
%21 = add i32 %19, %20 ; [#uses=1]
store i32 %21, i32* %k, align 4
store i32 100, i32* %l, align 4
store i32 0, i32* %sum, align 4
%22 = load i32* %a_addr, align 4 ; [#uses=1]
%23 = load i32* %b_addr, align 4 ; [#uses=1]
%24 = load i32* %h_addr, align 4 ; [#uses=1]
%25 = call i32 @​func2(i32 %22, i32 %23, i32 %24) nounwind ; [#uses=1]
store i32 %25, i32* %sum, align 4
%26 = load i32* %sum, align 4 ; [#uses=1]
%27 = call i32 (i8*, ...)* @​printf(i8* getelementptr ([16 x i8]* @.str, i32 0, i32 0), i32 %26) nounwind ; [#uses=0]
%28 = load i32* %i, align 4 ; [#uses=1]
%29 = call i32 (i8*, ...)* @​printf(i8* getelementptr ([14 x i8]* @.str1, i32 0, i32 0), i32 %28) nounwind ; [#uses=0]
%30 = load i16* %v_addr, align 2 ; [#uses=1]
%31 = sext i16 %30 to i32 ; [#uses=1]
%32 = call i32 (i8*, ...)* @​printf(i8* getelementptr ([14 x i8]* @.str2, i32 0, i32 0), i32 %31) nounwind ; [#uses=0]
%33 = load i64* %x_addr, align 8 ; [#uses=1]
%34 = call i32 (i8*, ...)* @​printf(i8* getelementptr ([16 x i8]* @.str3, i32 0, i32 0), i64 %33) nounwind ; [#uses=0]
%35 = load i8* %z_addr, align 1 ; [#uses=1]
%36 = sext i8 %35 to i32 ; [#uses=1]
%37 = call i32 (i8*, ...)* @​printf(i8* getelementptr ([14 x i8]* @.str4, i32 0, i32 0), i32 %36) nounwind ; [#uses=0]
%38 = load i32* %l, align 4 ; [#uses=1]
store i32 %38, i32* %0, align 4
%39 = load i32* %0, align 4 ; [#uses=1]
store i32 %39, i32* %retval, align 4
br label %return

return: ; preds = %entry
%retval1 = load i32* %retval ; [#uses=1]
ret i32 %retval1
}

declare i32 @​printf(i8*, ...) nounwind

define i32 @​main() nounwind {
entry:
%retval = alloca i32 ; <i32*> [#uses=2]
%l = alloca i8 ; <i8*> [#uses=2]
%k = alloca i64, align 8 ; <i64*> [#uses=2]
%j = alloca i16 ; <i16*> [#uses=2]
%i = alloca i32 ; <i32*> [#uses=2]
%h = alloca i32 ; <i32*> [#uses=2]
%g = alloca i32 ; <i32*> [#uses=2]
%f = alloca i32 ; <i32*> [#uses=2]
%e = alloca i32 ; <i32*> [#uses=2]
%d = alloca i32 ; <i32*> [#uses=2]
%c = alloca i32 ; <i32*> [#uses=2]
%b = alloca i32 ; <i32*> [#uses=2]
%a = alloca i32 ; <i32*> [#uses=2]
%0 = alloca i32 ; <i32*> [#uses=2]
%"alloca point" = bitcast i32 0 to i32 ; [#uses=0]
store i32 1, i32* %a, align 4
store i32 2, i32* %b, align 4
store i32 3, i32* %c, align 4
store i32 4, i32* %d, align 4
store i32 5, i32* %e, align 4
store i32 6, i32* %f, align 4
store i32 7, i32* %g, align 4
store i32 8, i32* %h, align 4
store i16 9, i16* %j, align 2
store i64 9876534123, i64* %k, align 8
store i8 -10, i8* %l, align 1
%1 = load i8* %l, align 1 ; [#uses=1]
%2 = sext i8 %1 to i32 ; [#uses=1]
%3 = load i16* %j, align 2 ; [#uses=1]
%4 = sext i16 %3 to i32 ; [#uses=1]
%5 = load i32* %a, align 4 ; [#uses=1]
%6 = load i32* %b, align 4 ; [#uses=1]
%7 = load i32* %c, align 4 ; [#uses=1]
%8 = load i32* %d, align 4 ; [#uses=1]
%9 = load i32* %e, align 4 ; [#uses=1]
%10 = load i32* %f, align 4 ; [#uses=1]
%11 = load i32* %g, align 4 ; [#uses=1]
%12 = load i32* %h, align 4 ; [#uses=1]
%13 = trunc i32 %4 to i16 ; [#uses=1]
%14 = load i64* %k, align 8 ; [#uses=1]
%15 = trunc i32 %2 to i8 ; [#uses=1]
%16 = call i32 @​func(i32 %5, i32 %6, i32 %7, i32 %8, i32 %9, i32 %10, i32 %11, i32 %12, i16 signext %13, i64 %14, i8 signext %15) nounwind ; [#uses=1]
store i32 %16, i32* %i, align 4
%17 = load i32* %i, align 4 ; [#uses=1]
store i32 %17, i32* %0, align 4
%18 = load i32* %0, align 4 ; [#uses=1]
store i32 %18, i32* %retval, align 4
br label %return

return: ; preds = %entry
%retval1 = load i32* %retval ; [#uses=1]
ret i32 %retval1
}

[lattner]

Please attach a C testcase. ABI issues are handled by both the front-end and LLC. If you are generating IR yourself, you have to handle these issues.

[llvmbot]

int func2(int a, int b, int h) {
return a+b+h;
}

int func(int a, int b, int c, int d, int e, int f, int g, int h, short j, long long k, char l) {
int i = a+b+c+d+e+f+g+h;
int j = i + a;
int k = j + b;
//int l = k + h;
int l = 100;
int sum = 0;
sum = func2(a, b, h);
printf("Test: sum = %d\n", sum);
//printf("Test: i = %d\n", i);
//return i;
return l;
}

int main() {
int a,b,c,d,e,f,g,h,i;
short j;
long long k;
char l;
a = 1;
b = 2;
c = 3;
d = 4;
e = 5;
f = 6;
g = 7;
h = 8;
j = 9;
k = 9876534123;
l = 10;

i = func(a,b,c,d,e,f,g,h,j,k,l);
return i;
}

[lattner]

your testcase doesn't build:

t.c: In function ‘func’:
t.c:8: error: ‘j’ redeclared as different kind of symbol
t.c:5: error: previous definition of ‘j’ was here
t.c:9: error: ‘k’ redeclared as different kind of symbol
t.c:6: error: previous definition of ‘k’ was here
t.c:11: error: ‘l’ redeclared as different kind of symbol
t.c:6: error: previous definition of ‘l’ was here
t.c:14: warning: incompatible implicit declaration of built-in function ‘printf’
t.c: In function ‘main’:
t.c:34: warning: integer constant is too large for ‘long’ type

[llvmbot]

your testcase doesn't build:

t.c: In function ‘func’:
t.c:8: error: ‘j’ redeclared as different kind of symbol
t.c:5: error: previous definition of ‘j’ was here
t.c:9: error: ‘k’ redeclared as different kind of symbol
t.c:6: error: previous definition of ‘k’ was here
t.c:11: error: ‘l’ redeclared as different kind of symbol
t.c:6: error: previous definition of ‘l’ was here
t.c:14: warning: incompatible implicit declaration of built-in function
‘printf’
t.c: In function ‘main’:
t.c:34: warning: integer constant is too large for ‘long’ type

sorry, the parameter to func has been modified when I used the source code to test other case.

int func2(int a, int b, int h) {
return a+b+h;
}

int func(int a, int b, int c, int d, int e, int f, int g, int h, short v, long
long x, char z) {
int i = a+b+c+d+e+f+g+h;
int j = i + a;
int k = j + b;
//int l = k + h;
int l = 100;
int sum = 0;
sum = func2(a, b, h);
printf("Test: sum = %d\n", sum);
//printf("Test: i = %d\n", i);
//return i;
return l;
}

int main() {
int a,b,c,d,e,f,g,h,i;
short j;
long long k;
char l;
a = 1;
b = 2;
c = 3;
d = 4;
e = 5;
f = 6;
g = 7;
h = 8;
j = 9;
k = 9876534123;
l = 10;

i = func(a,b,c,d,e,f,g,h,j,k,l);
return i;
}

[lattner]

Is this still a problem?

[llvmbot]

I'm not convinced it ever was a problem. The last example works correctly on (darwin) ppc32, although it doesn't appear to test what he says is wrong. Let's close it; if there's something wrong, please provide an example that demonstrates it.

[lattner]

Sounds good, thanks Dale.