clang miscompilation

[pwo]

Bugzilla Link	3673
Resolution	FIXED
Resolved on	Mar 12, 2010 00:55
Version	unspecified
OS	FreeBSD
Attachments	diff of .s files

Extended Description

The following program SEGV's when built with clang, llvm-gcc and gcc work fine.

#include <db.h>
#include <fcntl.h>
#include <stdio.h>

static DB *symtable;

int
main(void)
{
printf("dbopen()\n");
symtable = dbopen(/filename/NULL,
O_CREAT | O_NONBLOCK | O_RDWR, /mode/0, DB_HASH,
/openinfo/NULL);
printf("after dbopen()\n");
}

(gdb) break main
Breakpoint 1 at 0x4005c8: file t.c, line 10.
(gdb) run
Starting program: /tmp/t

Breakpoint 1, main () at t.c:10
10 printf("dbopen()\n");
(gdb) step
dbopen()
11 symtable = dbopen(/filename/NULL,
(gdb)

Program received signal SIGSEGV, Segmentation fault.
0x00000008007152fc in __bt_open () from /lib/libc.so.7

[pwo]

Program was built with ccc -g -o t t.c on FreeBSD/amd64

[lattner]

Does the code work correctly without -g? Can you please attach a .i file so we can repro it without your system headers?

[pwo]

Without -g does not make a difference, pre-processed dbopen-bug.c attached.
The dbopen() function is in freebsd's libc, that library is built with gcc 4.2.1.

[pwo]

Pre-processed dbopen-bug.c

[lattner]

Daniel, a potential x86-64 abi issue?

[llvmbot]

Index: lib/CodeGen/CGCall.cpp

--- lib/CodeGen/CGCall.cpp (revision 65532)
+++ lib/CodeGen/CGCall.cpp (working copy)
@@ -522,6 +522,9 @@
// FIXME: _Decimal32 and _Decimal64 are SSE.
// FIXME: _float128 and _Decimal128 are (SSE, SSEUp).
// FIXME: __int128 is (Integer, Integer).

• } else if (const EnumType *ET = Ty->getAsEnumType()) {
• // Classify the underlying integer type.
• classify(ET->getDecl()->getIntegerType(), Context, OffsetBase, Lo, Hi);
  } else if (Ty->isPointerLikeType() || Ty->isBlockPointerType() ||
  Ty->isObjCQualifiedIdType() ||
  Ty->isObjCQualifiedInterfaceType()) {

Fixes the test case for me, not sure if it's correct though :)

[pwo]

Patch as commited fixes the problem, thanks!

[llvmbot]

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090223/013123.html