[PATCH] llvm-config's Makefile: change sed's delimiter

[llvmbot]

Bugzilla Link	3727
Resolution	FIXED
Resolved on	Mar 10, 2009 14:03
Version	trunk
OS	Linux
Reporter	LLVM Bugzilla Contributor
CC	@sunfishcode,@nlewycky

Extended Description

llvm-config's Makefile uses sed with a delimiter of comma to build the final version of the script. This causes problems when building in, e.g., Fedora, since some compiler options passed by default contain commas, e.g.:

-Wp,-D_FORTIFY_SOURCE=2

We have carried this patch since llvm 2.1, but for some reason the patch has never been upstreamed. If this could be applied, we could drop it from our tree.

(Also, if someone could ping the Ocaml binding maintainer, this bug: http://llvm.org/bugs/show_bug.cgi?id=3153 has a patch that applies to LLVM 2.4 and 2.5)

[sunfishcode]

proposed patch
Could you attach your patch to this bugzilla? Alternatively,
could you test the patch that I'm attaching now? Thanks.

[llvmbot]

Fedora's sed patch
Oops. Here it is -- and yes, yours work fine.

[sunfishcode]

Thanks. I applied my patch, as it's slightly more general.
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090309/074978.html