clang-format AlwaysBreakConstructorInitializers

[llvmbot]

Bugzilla Link	43901
Version	unspecified
OS	Windows NT
Reporter	LLVM Bugzilla Contributor
CC	@mydeveloperday

Extended Description

I was wondering if it would be possible to add an option to always break constructor initializers. For example:

AlwaysBreakConstructorInitializers (booL)

if true, always break the constructor initializer list, regardless if they can all fit on a single line (the style is dictated by BreakConstructorInitializers:

true:
Constructor() :
initializer1(),
initializer2()

false:
Constructor() : initializer1(), initializer2()

IMO... clang-format works too hard to get everything to fit on a single line, but this specific instance really makes the code hard to read. It also makes it had to add // NOLINT tags as clang-format will move the comment around. For example:

Constructor() : // NOLINT
initializer1(),
initializer2()

becomes

Constructor() :
// NOLINT
initializer1(),
initializer2()

[mydeveloperday]

When logging a bug let us know what version of clang-format you are using (clang-format --version)

I'll repeat the normal documented mantra about adding a new style (not that I'm a fan of the policy myself)

Do we see a style guide for a large-ish publically available project that quotes this as a requirement in their style guide?

see https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options

Did you try playing with AllowAllConstructorInitializersOnNextLine , and ConstructorInitializerAllOnOneLineOrOnePerLine? (looking at the documentation it suggests it should do what you want but the example doesn't look convincing)

https://clang.llvm.org/docs/ClangFormatStyleOptions.html

[owenca]

https://reviews.llvm.org/D129057

[owenca]

I was wondering if it would be possible to add an option to always break constructor initializers.

An equivalent option PackConstructorInitializers: Never was added in 8a780a2.