Poor diagnostics with qualified name lookup

[DougGregor]

Bugzilla Link	3990
Resolution	FIXED
Resolved on	Mar 06, 2010 14:00
Version	unspecified
OS	All
CC	@DougGregor

Extended Description

This code:

namespace N {
struct Wibble {
};

typedef Wibble foo;
}
using namespace N;

foo::bar x;

void f() {
foo::bar = 4;
}

Gives very poor diagnostics:

foo.cpp:9:6: error: unknown type name 'bar'
foo::bar x;

foo.cpp:12:6: error: no member named 'bar'
foo::bar  = 4;
~~~~~^
2 diagnostics generated.

For the first error, we should say something like:

  error: unknown type name 'foo::bar'

in the second case, perhaps

  error: no member named 'bar' in 'foo' (aka 'struct N::Wibble')

G++ does something like this:

foo.cpp:9: error: ‘bar’ in class ‘N::foo’ does not name a type
foo.cpp: In function ‘void f()’:
foo.cpp:12: error: ‘bar’ is not a member of ‘N::foo’

[lattner]

Thanks for filing this Doug!

[DougGregor]

Fixed here:

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20091012/022294.html

We now get:

test/SemaCXX/unknown-type-name.cpp:12:6: error: no type named 'bar' in
'struct N::Wibble'
foo::bar x; // expected-error{{no type named 'bar' in 'struct N::Wibble'}}

test/SemaCXX/unknown-type-name.cpp:15:8: error: no member named 'bar' in
      'struct N::Wibble'
  foo::bar  = 4; // expected-error{{no member named 'bar' in 'struct ...
  ~~~~~^

[lattner]

nice!!