Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GFX1010 #44186

Closed
FFY00 opened this issue Feb 7, 2020 · 10 comments · Fixed by #78884
Closed

Add support for GFX1010 #44186

FFY00 opened this issue Feb 7, 2020 · 10 comments · Fixed by #78884
Labels
bugzilla Issues migrated from bugzilla cmake Build system in general and CMake in particular enhancement Improving things as opposed to bug fixing, e.g. new or missing feature libclc libclc OpenCL library

Comments

@FFY00
Copy link

FFY00 commented Feb 7, 2020

Bugzilla Link 44841
Version unspecified
OS Linux
CC @tstellar,@zboszor

Extended Description

Hello, would it be possible to add support for GFX1010 (NAVI10)? Is there anything blocking it? What are the first steps?

@zboszor
Copy link
Contributor

zboszor commented Feb 22, 2021

Add alias symlinks for missing AMD gfx9 and gfx10 generations
Probably something like the attached patch should work.
It did work on my Renoir based laptop by adding the gfx909 symlinks manually in Fedora 33 with LLVM 11.
The patch was made against the LLVM 12 release branch but it's applicable to the main branch, too.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 1, 2022

@llvm/issue-subscribers-backend-amdgpu

@terminatorul
Copy link

I tried the linking gfx909 to tahiti for my Radeon Graphics (Vega 8) iGPU for Ryzen 7 5700G, and Mesa-libOpenCL (Clover) only appeared to work, but not really.

Luxball scene in LuxMark v3.1 never showed up, and my desktop session crashed and I had to login again. Trying again LuxMark crashed with a strange error "CS (-1) was rejected, but it is not stable".
OpenSUSE Tumbleweed 20230313, Mesa 23.0.0

@cezarlamann
Copy link

Hello everyone! I'm a noob using llvm for anything, and I'd like to use CLBlast with my AMD Renoir APU (R7-4700U GFX 909 GCN 5.1), which requires LLVM to support gfx909. What can we do to get this working?

@jayfoad jayfoad added the OpenCL label Jul 31, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 31, 2023

@llvm/issue-subscribers-opencl

@jayfoad
Copy link
Contributor

jayfoad commented Jul 31, 2023

This is a libclc issue. (That was obvious from the original bugzilla but got lost in the transition to github.)

@RKSimon RKSimon added the libclc libclc OpenCL library label Jul 31, 2023
@peci1
Copy link

peci1 commented Sep 24, 2023

Detailed debugging info (and steps to repro) added in #52665 (comment) (for gfx909).

@Endilll Endilll added the enhancement Improving things as opposed to bug fixing, e.g. new or missing feature label Sep 26, 2023
@tstellar
Copy link
Collaborator

Add alias symlinks for missing AMD gfx9 and gfx10 generations Probably something like the attached patch should work. It did work on my Renoir based laptop by adding the gfx909 symlinks manually in Fedora 33 with LLVM 11. The patch was made against the LLVM 12 release branch but it's applicable to the main branch, too.

Could someone submit this patch as a pull request?

@lorn10
Copy link

lorn10 commented Jan 20, 2024

A short addition. Even if we have 2024 and this topic is quite old it would probably still make sense to add some RDNA and GCN5 support in libclc.

I mean this especially in regard to the (as of early 2024) quite fluctuating stability of rusticl and also the "not so good" rust support of older distros like (K)Ubuntu 22.04 LTS. Ergo it may take quite some time until rusticl (and the rust infrastructure) will be improved.

An updated libclc would enable also on more modern Radeon class hardware some sort of OpenCL support with clover.

I could try to make a merge or "pull" request with the above mentioned patch but I have unfortunately not really a clue what I would do. So for the first here follows a gently ping to @zboszor. 😉

@zboszor
Copy link
Contributor

zboszor commented Jan 21, 2024

A short addition. Even if we have 2024 and this topic is quite old it would probably still make sense to add some RDNA and GCN5 support in libclc.

I mean this especially in regard to the (as of early 2024) quite fluctuating stability of rusticl and also the "not so good" rust support of older distros like (K)Ubuntu 22.04 LTS. Ergo it may take quite some time until rusticl (and the rust infrastructure) will be improved.

An updated libclc would enable also on more modern Radeon class hardware some sort of OpenCL support with clover.

I could try to make a merge or "pull" request with the above mentioned patch but I have unfortunately not really a clue what I would do. So for the first here follows a gently ping to @zboszor. 😉

Thanks for reminding me, I wasn't following this bug.

The patch is now submitted as #78884 , extended with symlinks for more chip generations added since LLVM 12.

arsenm pushed a commit that referenced this issue Jan 22, 2024
Fixes #44186

---------

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
@EugeneZelenko EugeneZelenko added cmake Build system in general and CMake in particular and removed backend:AMDGPU OpenCL labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla cmake Build system in general and CMake in particular enhancement Improving things as opposed to bug fixing, e.g. new or missing feature libclc libclc OpenCL library
Projects
None yet
Development

Successfully merging a pull request may close this issue.