Skip to content

Don't print "Section: <?>" for ET_CORE file note printing #48432

Open
@jh7370

Description

@jh7370
Bugzilla Link 49088
Version trunk
OS Windows NT
CC @jh7370

Extended Description

Spun off from https://reviews.llvm.org/D74393. LLVM style printing of ELF notes can be a little confusing for ET_CORE files, and quite possibly other ELFs with no sections. In such cases, rather than printing a section name for each note region (e.g. "Section: .note.foo"), llvm-readobj simply prints "Section: <?>", which could lead people to wonder, why can't llvm-readobj load the section name for this ELF? It would be less confusing if it simply didn't print the "Section:" line in those situations (the offset and size is already printed, so there is still enough information to find the note data if needed). This would be similar to GNU style printing which prints "Displaying notes found at file offset xxxxx with length xxxxx:" instead of "Displaying notes found in: .note.foo".

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions