//comment line breaks switch case format style

[mplexor]

Language:        Cpp
AllowShortCaseLabelsOnASingleLine : true    

  switch (0) {
  case 0:    test();    break;
    // line above style should not be affected by comment
  }

[llvmbot]

@llvm/issue-subscribers-clang-format

[llvmbot]

@llvm/issue-subscribers-bug

[mkurdej]

Hmm, when the code is like this:

switch (0) {
case 0: test(); break; // comment
}

then the formatting leaves it as is.

[mplexor]

assume other cases bellow commented out, should not affect lines above...
//case 1: ...
//case 2: ...

[mydeveloperday]

Can you be clear about the "what you start with", "what you see" and "what you are expecting"

[mplexor]

again, case 0 line gets split into lines, and purely due to comment line bellow (which shouldnt).

  switch (0) {
  case 0: test0(); break;
    // case 1: test1(); break; // line above style should not be affected by comment
  case 2: test2(); break;
  }

after:

switch (0) {
	case 0:
		test0();
		break;
		// case 1: test1(); break; // line above style should not be affected by comment
	case 2: test2(); break;
}

[mkurdej]

Interestingly, when there's no whitespace before the comment, then the formatting is as expected:

switch (0) {
case 0: test0(); break;
// case 1: test1(); break;
case 2: test2(); break;
}

stays like this.

Otherwise, i.e. when there's a space before the comment, clang-format considers the comment as appertaining to the previous case label and so it breaks it.

Looking at the tests, I think it's by design, so as to handle e.g. // fall through comments (but not only).
I think we can close this issue. WDYT?

[mkurdej]

@mydeveloperday, I'd like to hear your opinion here.

[mplexor]

tbh looking for alternative formatter, this one seems long before usable.
none of expected basic things are working or fixed
closing all issues

[EugeneZelenko]

Please give developers time to address problems.