[clang-format] de-indentation of a block comment does not work without ReflowComments

[lahwaacz]

Consider this repro code:

class A
{
    public:
        /**
         * \brief Some fancy method.
         */
        void foo();
};

When the ReflowComments option is disabled, clang-format breaks the formatting:

$ clang-format --style="{ReflowComments: false}" foo.cpp
class A {
public:
  /**
         * \brief Some fancy method.
         */
  void foo();
};

Tested with clang-format version 13.0.0

[llvmbot]

@llvm/issue-subscribers-clang-format

[mydeveloperday]

I'm not 100% sure what I think about this... regardless of ReflowComments being true or false I get the same

and I don't think its related to the class or the public or the indentation or the /** or the \brief as the same is true for the following

  /*  
         * brief Some fancy method.
         */
  void foo();

Do we think it should reformat first and foremost? (before considering it a bug or enhancement)

@mkurdej what do you think?

[lahwaacz]

To clarify, with ReflowComments: true I get the expected output:

$ clang-format --style="{ReflowComments: true}" foo.cpp
class A {
public:
  /**
   * \brief Some fancy method.
   */
  void foo();
};

If this behavior is expected only for ReflowComments: true (i.e. ReflowComments: false above behaves as expected), it should be at least documented for the ReflowComments option, because the term "reflow" is unrelated to indentation (it means wrapping overly long lines and joining the text on the following lines).

[DougLeonard]

This seems like a bug, or at least a clearly needed option. The only solution now is to sed all /* comments to // or ///.