RUNPATH not regard LLVM_ENABLE_PER_TARGET_RUNTIME_DIR

[songdongsheng]

When build LLVM/CLang release/14.x with -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON and -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-unknown-linux-gnu:

$ readelf -d clang-14 | grep RUNPATH
  0x000000000000001d (RUNPATH)      Library runpath: [$ORIGIN/../lib]

It should be:

$ readelf -d clang-14 | grep RUNPATH
  0x000000000000001d (RUNPATH)      Library runpath: [$ORIGIN/../lib:$ORIGIN/../lib/x86_64-unknown-linux-gnu]

[lygstate]

readelf -d clang-14 | grep RUNPATH
0x000000000000001d (RUNPATH) Library runpath: [$ORIGIN/../lib:$ORIGIN/../lib/x86_64-unknown-linux-gnu]

I think $ORIGIN/../lib/x86_64-unknown-linux-gnu should have higher priority

[arcivanov]

It's worse than that. When the LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF, the libc++ et al still end up in the target triple directory due to these just as an example:

llvm-project/llvm/runtimes/CMakeLists.txt

Line 88 in 5f66e72

-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=${LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default}

llvm-project/llvm/runtimes/CMakeLists.txt

Line 240 in 5f66e72

-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=${LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default}

[arcivanov]

https://reviews.llvm.org/D126122

[DoDoENT]

I confirm that patch by @arcivanov works for us as well.

[DoDoENT]

I just spent over a day debugging the same issue with LLVM 16, thinking that this patch was already merged. Any idea when it will be merged into the trunk?

[arcivanov]

No clue, the maintainers requested changes that broke CMake. Please see https://reviews.llvm.org/D126122#4225512 and later.

I sort of moved on carrying my own patch in a tree: https://github.com/karellen/karellen-llvm/blob/master/patches/001-runpath.patch

[DoDoENT]

I sort of moved on carrying my own patch in a tree

I'll do the same in my fork. Thank you for the patch anyway 😉