Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLSL] Support packoffset attribute for cbuffer #57914

Open
Tracked by #41
python3kgae opened this issue Sep 22, 2022 · 1 comment
Open
Tracked by #41

[HLSL] Support packoffset attribute for cbuffer #57914

python3kgae opened this issue Sep 22, 2022 · 1 comment
Assignees
@python3kgae
Labels
HLSL HLSL Language Support

Comments

@python3kgae
Copy link
Contributor

python3kgae commented Sep 22, 2022 •
edited by davidcook-msft

Documentation for packoffset is at
https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-variable-packoffset

AC

  • A design is created that defines how we will lower this to DXIL
  • This is only the parsing support for packoffset, does not include the lowering
  • Goes through code-gen to IR metadata
  • Tests for the IR representation are created
@python3kgae python3kgae added the HLSL HLSL Language Support label Sep 22, 2022
@davidcook-msft
Copy link

Additional tasks needed:

  • IR lowering to DXIL task
  • @bogner to create additional task

@python3kgae python3kgae mentioned this issue Apr 23, 2024
Merged
python3kgae added a commit that referenced this issue May 8, 2024
@python3kgae
[HLSL] Support packoffset attribute in AST (#89836)
c5509fe 
Add HLSLPackOffsetAttr to save packoffset in AST.

Since we have to parse the attribute manually in ParseHLSLAnnotations,
we could create the ParsedAttribute with a integer offset parameter
instead of string. This approach avoids parsing the string if the offset
is saved as a string in HLSLPackOffsetAttr.

For #57914.
@python3kgae python3kgae mentioned this issue May 8, 2024
Merged
python3kgae added a commit that referenced this issue May 9, 2024
@python3kgae
[HLSL] reenable add packoffset in AST (#91474)
41f0574 
This reapplies
c5509fe
"[HLSL] Support packoffset attribute in AST
(#89836)" with a fix for the
test failure caused by missing -fnative-half-type.

Since we have to parse the attribute manually in ParseHLSLAnnotations,
we could create the ParsedAttribute with an integer offset parameter
instead of string. This approach avoids parsing the string if the offset
is saved as a string in HLSLPackOffsetAttr.

For #57914
@damyanp damyanp mentioned this issue Jul 30, 2024
Open
@damyanp damyanp mentioned this issue Aug 22, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@python3kgae python3kgae

Labels
HLSL HLSL Language Support
Projects
HLSL Support
Status: Active
Milestone
No milestone
Development

No branches or pull requests
2 participants
@python3kgae @davidcook-msft