`CLANG_RESOURCE_DIR` is not respected in some subprojects

[paperchalice]

There is a configurable variable CLANG_RESOURCE_DIR, if I understand the docstring and source code correctly, some subprojects should install their files like headers, into this directory.

llvm-project/clang/lib/Driver/Driver.cpp

Line 232 in 21c4dc7

ResourceDir = GetResourcesPath(ClangExecutable, CLANG_RESOURCE_DIR);

llvm-project/clang/lib/Driver/Driver.cpp

Lines 176 to 186 in 21c4dc7

	if (CustomResourceDir != "") {
	llvm::sys::path::append(P, CustomResourceDir);
	} else {
	// On Windows, libclang.dll is in bin/.
	// On non-Windows, libclang.so/.dylib is in lib/.
	// With a static-library build of libclang, LibClangPath will contain the
	// path of the embedding binary, which for LLVM binaries will be in bin/.
	// ../lib gets us to lib/ in both cases.
	P = llvm::sys::path::parent_path(Dir);
	llvm::sys::path::append(P, CLANG_INSTALL_LIBDIR_BASENAME, "clang",
	CLANG_VERSION_MAJOR_STRING);

---

clang:

llvm-project/clang/lib/Headers/CMakeLists.txt

Line 285 in 95956bd

set(output_dir ${LLVM_LIBRARY_OUTPUT_INTDIR}/clang/${CLANG_VERSION_MAJOR}/include)

llvm-project/clang/lib/Tooling/CMakeLists.txt

Line 64 in 95956bd

-I ${LLVM_BINARY_DIR}/lib/clang/${CLANG_VERSION_MAJOR}/include

compiler-rt:

llvm-project/compiler-rt/cmake/base-config-ix.cmake

Lines 46 to 48 in 5a3a527

	set(COMPILER_RT_OUTPUT_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/clang/${CLANG_VERSION_MAJOR})
	set(COMPILER_RT_EXEC_OUTPUT_DIR ${LLVM_RUNTIME_OUTPUT_INTDIR})
	set(COMPILER_RT_INSTALL_PATH lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION_MAJOR})

llvm:

llvm-project/llvm/cmake/modules/LLVMExternalProjectUtils.cmake

Line 260 in 5a3a527

set(resource_dir "${LLVM_LIBRARY_DIR}/clang/${CLANG_VERSION_MAJOR}")

openmp:

llvm-project/openmp/CMakeLists.txt

Line 90 in 5a3a527

set(LIBOMP_HEADERS_INSTALL_PATH "${OPENMP_INSTALL_LIBDIR}/clang/${CLANG_VERSION}/include")

[EugeneZelenko]

@paperchalice: Could you please elaborate?

[paperchalice]

Closed by 0beffb8, Differential Revision: https://reviews.llvm.org/D141907

[tuliom]

/cherry-pick a809720 6888de1

[llvmbot]

/cherry-pick a809720 6888de1

Error: Command failed due to missing milestone.

[tuliom]

/cherry-pick a809720 6888de1

[llvmbot]

/branch llvm/llvm-project-release-prs/issue59726