clang-format 16 doesn't respect BreakAfterAttributes option for constructors

[calcmogul]

When the BreakAfterAttributes option in clang-format 16 is set to Always, it introduces a newline after attributes for member functions, but not for constructors. It seems like it should break after attributes for constructors as well.

Example input in a file called Test.cpp:

class Test {
public:
  [[deprecated]] Test(int);

  [[deprecated("msg")]] Test(double);

  [[deprecated]] void Func1();

  [[deprecated("msg")]] void Func2();
};

Command:

clang-format --style="{BreakAfterAttributes: Always}" Test.cpp

Expected output:

class Test {
public:
  [[deprecated]]
  Test(int);

  [[deprecated("msg")]]
  Test(double);

  [[deprecated]]
  void Func1();

  [[deprecated("msg")]]
  void Func2();
};

Actual output:

class Test {
public:
  [[deprecated]] Test(int);

  [[deprecated("msg")]] Test(double);

  [[deprecated]]
  void Func1();

  [[deprecated("msg")]]
  void Func2();
};

[calcmogul]

Here's the commit the option was added in:
a28f074

The comment True if breaking after last attribute group in function return type implies that the attribute breaking is tied to the return type, but constructors don't have return types.

[llvmbot]

@llvm/issue-subscribers-clang-format

[owenca]

Actually, this is because clang-format doesn't annotate constructors as FunctionDeclarationName.

[owenca]

https://reviews.llvm.org/D157963