[bolt] 16.0.5: cmake fails

[kloczek]

I'm trying to build bolt using https://github.com/llvm/llvm-project//releases/download/llvmorg-16.0.5//bolt-16.0.5.src.tar.xz

I'm not sure but on first look it looks like no one have been trying to build bold out of that tar ball because cmake warns on missing projrect() and cmake fails
I'm building bolt using set of cmake params like below:

%build
%cmake \
        -D BOLT_CLANG_EXE=%{_bindir}/clang \
        -D BOLT_INCLUDE_DOCS=ON \
        -D BOLT_INCLUDE_TESTS=ON \
        -D BOLT_LLD_EXE=%{_bindir}/ld.lld \
        -D BUILD_SHARED_LIBS=OFF \
        -D CMAKE_SKIP_RPATH=ON \
        -D LLVM_BUILD_UTILS=ON \
        -D LLVM_DIR=%{_libdir}/cmake/llvm \
        -D LLVM_EXTERNAL_LIT=%{_bindir}/lit \
        -D LLVM_INCLUDE_TESTS=ON \
        -D LLVM_LINK_LLVM_DYLIB=OFF \
        -D LLVM_TABLEGEN_EXE=%{_bindir}/llvm-tblgen \
        -D LLVM_TARGETS_TO_BUILD="X86;AArch64" \
%if 0%{?__isa_bits} == 64
        -D LLVM_LIBDIR_SUFFIX=64 \
%else
        -D LLVM_LIBDIR_SUFFIX= \
%endif
        %{nil}
%cmake_build

and cmake fails with

+ /usr/bin/cmake -B x86_64-redhat-linux-gnu -D BUILD_SHARED_LIBS=ON -D CMAKE_AR=/usr/bin/gcc-ar -D CMAKE_BUILD_TYPE=RelWithDebInfo -D CMAKE_C_FLAGS_RELEASE=-DNDEBUG -D CMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -D CMAKE_Fortran_FLAGS_RELEASE=-DNDEBUG -D CMAKE_INSTALL_PREFIX=/usr -D CMAKE_NM=/usr/bin/gcc-nm -D CMAKE_RANLIB=/usr/bin/gcc-ranlib -D CMAKE_VERBOSE_MAKEFILE=ON -D INCLUDE_INSTALL_DIR=/usr/include -D LIB_INSTALL_DIR=/usr/lib64 -D LIB_SUFFIX=64 -D SHARE_INSTALL_PREFIX=/usr/share -D SYSCONF_INSTALL_DIR=/etc -S . -D BOLT_CLANG_EXE=/usr/bin/clang -D BOLT_INCLUDE_DOCS=ON -D BOLT_INCLUDE_TESTS=ON -D BOLT_LLD_EXE=/usr/bin/ld.lld -D BUILD_SHARED_LIBS=OFF -D CMAKE_SKIP_RPATH=ON -D LLVM_BUILD_UTILS=ON -D LLVM_DIR=/usr/lib64/cmake/llvm -D LLVM_EXTERNAL_LIT=/usr/bin/lit -D LLVM_INCLUDE_TESTS=ON -D LLVM_LINK_LLVM_DYLIB=OFF -D LLVM_TABLEGEN_EXE=/usr/bin/llvm-tblgen -D 'LLVM_TARGETS_TO_BUILD=X86;AArch64' -D LLVM_LIBDIR_SUFFIX=64
CMake Warning (dev) in CMakeLists.txt:
  No project() command is present.  The top-level CMakeLists.txt file must
  contain a literal, direct call to the project() command.  Add a line of
  code such as

    project(ProjectName)

  near the top of the file, but after cmake_minimum_required().

  CMake is pretending there is a "project(Project)" command on the first
  line.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  cmake_minimum_required() should be called prior to this top-level project()
  call.  Please see the cmake-commands(7) manual for usage documentation of
  both commands.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- The C compiler identification is GNU 13.1.1
-- The CXX compiler identification is GNU 13.1.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Warning (dev) at CMakeLists.txt:22 (if):
  Policy CMP0057 is not set: Support new IN_LIST if() operator.  Run "cmake
  --help-policy CMP0057" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  IN_LIST will be interpreted as an operator when the policy is set to NEW.
  Since the policy is not set the OLD behavior will be used.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at CMakeLists.txt:22 (if):
  if given arguments:

    "clang" "IN_LIST" "LLVM_ENABLE_PROJECTS" "AND" "BOLT_CLANG_EXE"

  Unknown arguments specified


CMake Warning (dev) in CMakeLists.txt:
  No cmake_minimum_required command is present.  A line of code such as

    cmake_minimum_required(VERSION 3.26)

  should be added at the top of the file.  The version specified may be lower
  if you wish to support older CMake versions for this project.  For more
  information run "cmake --help-policy CMP0000".
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring incomplete, errors occurred!

[llvmbot]

@llvm/issue-subscribers-bolt

[aaupov]

Please try disabling BOLT tests:

    -D BOLT_INCLUDE_TESTS=ON \

and remove the variables used by BOLT testing only:

    -D BOLT_CLANG_EXE=%{_bindir}/clang \
    -D BOLT_LLD_EXE=%{_bindir}/ld.lld \

I'm not sure if you need these testing variables:

    -D LLVM_EXTERNAL_LIT=%{_bindir}/lit \
    -D LLVM_INCLUDE_TESTS=ON \

And you may still need to specify this:

-DLLVM_ENABLE_PROJECTS=bolt

[kloczek]

And you may still need to specify this:

-DLLVM_ENABLE_PROJECTS=bolt

This implies that bolt cmake files are still not correctly detached from mono repo builds like it is in case of other LLVM subprojects.
I just tested

%build
%cmake \
        -D BOLT_INCLUDE_DOCS=ON \
        -D BOLT_INCLUDE_TESTS=OFF \
        -D BUILD_SHARED_LIBS=OFF \
        -D CMAKE_SKIP_RPATH=ON \
        -D LLVM_BUILD_UTILS=ON \
        -D LLVM_DIR=%{_libdir}/cmake/llvm \
        -D LLVM_ENABLE_PROJECTS=bolt \
        -D LLVM_INCLUDE_TESTS=OFF \
        -D LLVM_LINK_LLVM_DYLIB=OFF \
        -D LLVM_TABLEGEN_EXE=%{_bindir}/llvm-tblgen \
        -D LLVM_TARGETS_TO_BUILD="X86;AArch64" \
%if 0%{?__isa_bits} == 64
        -D LLVM_LIBDIR_SUFFIX=64 \
%else
        -D LLVM_LIBDIR_SUFFIX= \
%endif
        %{nil}
%cmake_build

And here is result

+ cd bolt-16.0.6.src
+ ASMFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none'
+ CFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none'
+ CXXFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none'
+ FFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -I/usr/lib64/gfortran/modules'
+ FCFLAGS='-O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -I/usr/lib64/gfortran/modules'
+ LDFLAGS='-Wl,--gc-sections -Wl,--as-needed -flto=auto -flto-partition=none -fuse-linker-plugin -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--build-id=sha1'
+ RUSTFLAGS='-C codegen-units=1 -C debuginfo=2 -C opt-level=2 -C link-arg=-fdata-sections -C link-arg=-ffunction-sections -C link-arg=-Wl,--as-needed -C link-arg=-Wl,-z,now -C link-arg=-Wl,-z,relro --cap-lints=warn'
+ VALAFLAGS=-g
+ CC=/usr/bin/gcc
+ CXX=/usr/bin/g++
+ FC=/usr/bin/gfortran
+ AR=/usr/bin/gcc-ar
+ NM=/usr/bin/gcc-nm
+ RANLIB=/usr/bin/gcc-ranlib
+ export ASMFLAGS CFLAGS CXXFLAGS FFLAGS FCFLAGS LDFLAGS VALAFLAGS CC CXX FC AR NM RANLIB RUSTFLAGS VALAFLAGS
+ /usr/bin/cmake -B x86_64-redhat-linux-gnu -D BUILD_SHARED_LIBS=ON -D CMAKE_AR=/usr/bin/gcc-ar -D CMAKE_BUILD_TYPE=RelWithDebInfo -D CMAKE_C_FLAGS_RELEASE=-DNDEBUG -D CMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -D CMAKE_Fortran_FLAGS_RELEASE=-DNDEBUG -D CMAKE_INSTALL_PREFIX=/usr -D CMAKE_NM=/usr/bin/gcc-nm -D CMAKE_RANLIB=/usr/bin/gcc-ranlib -D CMAKE_VERBOSE_MAKEFILE=ON -D INCLUDE_INSTALL_DIR=/usr/include -D LIB_INSTALL_DIR=/usr/lib64 -D LIB_SUFFIX=64 -D SHARE_INSTALL_PREFIX=/usr/share -D SYSCONF_INSTALL_DIR=/etc -S . -D BOLT_INCLUDE_DOCS=ON -D BOLT_INCLUDE_TESTS=OFF -D BUILD_SHARED_LIBS=OFF -D CMAKE_SKIP_RPATH=ON -D LLVM_BUILD_UTILS=ON -D LLVM_DIR=/usr/lib64/cmake/llvm -D LLVM_ENABLE_PROJECTS=bolt -D LLVM_INCLUDE_TESTS=OFF -D LLVM_LINK_LLVM_DYLIB=OFF -D LLVM_TABLEGEN_EXE=/usr/bin/llvm-tblgen -D 'LLVM_TARGETS_TO_BUILD=X86;AArch64' -D LLVM_LIBDIR_SUFFIX=64
CMake Warning (dev) in CMakeLists.txt:
  No project() command is present.  The top-level CMakeLists.txt file must
  contain a literal, direct call to the project() command.  Add a line of
  code such as

    project(ProjectName)

  near the top of the file, but after cmake_minimum_required().

  CMake is pretending there is a "project(Project)" command on the first
  line.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  cmake_minimum_required() should be called prior to this top-level project()
  call.  Please see the cmake-commands(7) manual for usage documentation of
  both commands.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- The C compiler identification is GNU 13.1.1
-- The CXX compiler identification is GNU 13.1.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Building BOLT runtime libraries for X86
CMake Error at CMakeLists.txt:69 (add_llvm_install_targets):
  Unknown CMake command "add_llvm_install_targets".


CMake Error in CMakeLists.txt:
  No cmake_minimum_required command is present.  A line of code such as

    cmake_minimum_required(VERSION 3.26)

  should be added at the top of the file.  The version specified may be lower
  if you wish to support older CMake versions for this project.  For more
  information run "cmake --help-policy CMP0000".


-- Configuring incomplete, errors occurred!

As wrote fact that cmake complains about missing project() is another sign that standalone bolt dist tar ball have not been tested (enough).

[kloczek]

Gentle ping .. any update? 🤔

[aaupov]

Sorry, couldn't get to work on that. If you can figure out what's wrong and fix it for yourself and others it would be awesome.

[kloczek]

Sorry, couldn't get to work on that. If you can figure out what's wrong and fix it for yourself and others it would be awesome.

As wrote fact that cmake complains about missing project() is another sign that standalone bolt dist tar ball have not been tested (enough).

[aaupov]

Wait, are you trying to build BOLT without LLVM? That's not expected to build (or even configure as we rely extensively on LLVM's CMake definitions).
I suggest you check how distros manage building llvm tools from the source: Debian, Gentoo, and adjust your scripts to do similar configuration. The source tarball was added with that use case in mind.

[kloczek]

Wait, are you trying to build BOLT without LLVM?

I'm trying to build bolt from bolt subproject dist tar ball with have installed llvm and clang (already build from subproject dist tar balls).

I suggest you check how distros manage building llvm

I'm MyDistro™️ LLVM building manger 😋

[Ristovski]

Can confirm I have run into this as well. It indeed appears that the standalone bolt tarball releases are broken.

[Ristovski]

I just checked and it seems like all other standalone projects use the following construction in their CMakeLists, examples:

lldb:

llvm-project/lldb/CMakeLists.txt

Lines 16 to 29 in 7cbf1a2

	# If we are not building as part of LLVM, build LLDB as a standalone project,
	# using LLVM as an external library.
	if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
	project(lldb)
	set(LLDB_BUILT_STANDALONE TRUE)
	set(LLVM_INCLUDE_TESTS ON CACHE INTERNAL "")
	if ("${CMAKE_VERSION}" VERSION_LESS "3.20.0")
	message(WARNING
	"Your CMake version is ${CMAKE_VERSION}. Starting with LLVM 17.0.0, the "
	"minimum version of CMake required to build LLVM will become 3.20.0, and "
	"using an older CMake will become an error. Please upgrade your CMake to "
	"at least 3.20.0 now to avoid issues in the future!")
	endif()
	endif()

flang:

llvm-project/flang/CMakeLists.txt

Lines 28 to 43 in 7cbf1a2

	# Check for a standalone build and configure as appropriate from
	# there.
	if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
	message("Building Flang as a standalone project.")
	project(Flang)
	set(FLANG_STANDALONE_BUILD ON)
	if ("${CMAKE_VERSION}" VERSION_LESS "3.20.0")
	message(WARNING
	"Your CMake version is ${CMAKE_VERSION}. Starting with LLVM 17.0.0, the "
	"minimum version of CMake required to build LLVM will become 3.20.0, and "
	"using an older CMake will become an error. Please upgrade your CMake to "
	"at least 3.20.0 now to avoid issues in the future!")
	endif()
	else()
	set(FLANG_STANDALONE_BUILD OFF)
	endif()

This snippet indeed defines the missing project() and these build just fine, which indicates it is only the bolt subproject that is currently missing support to be built out-of-tree from the released standalone tarball mentioned in the OP.