ast_matcher capturesVar assertion failed in debug mode

[qqiangwu]

llvm-project/clang/include/clang/ASTMatchers/ASTMatchers.h

Line 4818 in 2476e2a

AST_MATCHER_P(LambdaCapture, capturesVar, internal::Matcher<ValueDecl>,

AST_MATCHER_P(LambdaCapture, capturesVar, internal::Matcher<ValueDecl>,
              InnerMatcher) {
  auto *capturedVar = Node.getCapturedVar();
  return capturedVar && InnerMatcher.matches(*capturedVar, Finder, Builder);
}

  ValueDecl *getCapturedVar() const {
    assert(capturesVariable() && "No variable available for capture");
    return static_cast<ValueDecl *>(DeclAndBits.getPointer());
  }

The matcher relies on getCapturedVar returns nullptr if not captured, but the implementation asserts capturesVariable()

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Wu (qqiangwu)

https://github.com/llvm/llvm-project/blob/2476e2a91140b57ca3ad0792597be4f4d20ddb1a/clang/include/clang/ASTMatchers/ASTMatchers.h#L4818

AST_MATCHER_P(LambdaCapture, capturesVar, internal::Matcher<ValueDecl>,
              InnerMatcher) {
  auto *capturedVar = Node.getCapturedVar();
  return capturedVar && InnerMatcher.matches(*capturedVar, Finder, Builder);
}

  ValueDecl *getCapturedVar() const {
    assert(capturesVariable() && "No variable available for capture");
    return static_cast<ValueDecl *>(DeclAndBits.getPointer());
  }

The matcher relies on getCapturedVar returns nullptr if not captured, but the implementation asserts capturesVariable()

[shafik]

I believe this should be something like:

  auto *capturedVar = Node.capturesVariable() ? Node.getCapturedVar() : nullptr;

CC @cor3ntin