flang/lib/Lower/OpenACC.cpp:3211: possible performance problem ?

[dcb314]

Static analyser cppcheck says:

flang/lib/Lower/OpenACC.cpp:3211:53: performance: Function parameter 'declareGlobalName' should be passed by const reference. [passedByValue]

Source code is

static void createDeclareGlobalOp(mlir::OpBuilder &modBuilder,
fir::FirOpBuilder &builder,
mlir::Location loc, fir::GlobalOp globalOp,
mlir::acc::DataClause clause,
const std::string declareGlobalName,
bool implicit, std::stringstream &asFortran) {

[llvmbot]

@llvm/issue-subscribers-flang-ir

Author: None (dcb314)

Static analyser cppcheck says:

flang/lib/Lower/OpenACC.cpp:3211:53: performance: Function parameter 'declareGlobalName' should be passed by const reference. [passedByValue]

Source code is

static void createDeclareGlobalOp(mlir::OpBuilder &modBuilder,
fir::FirOpBuilder &builder,
mlir::Location loc, fir::GlobalOp globalOp,
mlir::acc::DataClause clause,
const std::string declareGlobalName,
bool implicit, std::stringstream &asFortran) {

[klausler]

#79769