llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h:285: Pointless string copy ?

[dcb314]

Static analyser cppcheck says:

llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h:285:38: performance: Function parameter 'Style' should be passed by const reference. [passedByValue]

Source code is

void setOutliningStyle(std::string Style) { OutliningStyle = Style; }

Maybe better code:

void setOutliningStyle( const std::string & Style) { OutliningStyle = Style; }

[llvmbot]

@llvm/issue-subscribers-backend-aarch64

Author: None (dcb314)

Static analyser cppcheck says:

llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h:285:38: performance: Function parameter 'Style' should be passed by const reference. [passedByValue]

Source code is

void setOutliningStyle(std::string Style) { OutliningStyle = Style; }

Maybe better code:

void setOutliningStyle( const std::string & Style) { OutliningStyle = Style; }