[mlir] Unbreak msvc build. NFC. #102627
Closed
[mlir] Unbreak msvc build. NFC. #102627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still seems to fail with C++17 unless I'm missing something: https://godbolt.org/z/xYdqccW3s It does seem to work with C++20. |
|
I did not experiment with version flags. I can accept your version if that one works. |
|
My version seems to always work so I think that would make the most sense. |
|
Retract in favor of #101021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ec50f58, compiling the unittests fail with
I think this is legal, as calling a lambda recursively is legal as well, as long as the declarator's type does not depend on the lambda's type. Explicitly listing the captures unbreaks the build for msvc. While it compiles, IntelliSense still shows it as error (red squiggly line).
Alternative to #101021