Skip to content

[LLDB]Skip Summary Statistics Tests for Windows #108079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Jlalond
Copy link
Contributor

@Jlalond Jlalond commented Sep 10, 2024

Follow up to #102708, the tests are failing for windows. There is a large variance in these tests between summary strings and built in types. I'm disabling these test for windows, and will add windows specific tests as a follow up to this.

@Jlalond Jlalond requested a review from Michael137 September 10, 2024 20:10
@Jlalond Jlalond changed the title Skip Summary Statistics Tests for Windows [LLDB]Skip Summary Statistics Tests for Windows Sep 10, 2024
@llvmbot llvmbot added the lldb label Sep 10, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 10, 2024

@llvm/pr-subscribers-lldb

Author: Jacob Lalonde (Jlalond)

Changes

Follow up to #102708, the tests are failing for windows. There is a large variance in these tests between summary strings and built in types. I'm disabling these test for windows, and will add windows specific tests as a follow up to this.


Full diff: https://github.com/llvm/llvm-project/pull/108079.diff

1 Files Affected:

  • (modified) lldb/test/API/commands/statistics/basic/TestStats.py (+2)
diff --git a/lldb/test/API/commands/statistics/basic/TestStats.py b/lldb/test/API/commands/statistics/basic/TestStats.py
index 03ec1693447051..a0a9eeb6493207 100644
--- a/lldb/test/API/commands/statistics/basic/TestStats.py
+++ b/lldb/test/API/commands/statistics/basic/TestStats.py
@@ -921,6 +921,7 @@ def test_order_of_options_do_not_matter(self):
                 f"The order of options '{options[0]}' and '{options[1]}' should not matter",
             )
 
+    @skipIfWindows
     def test_summary_statistics_providers(self):
         """
         Test summary timing statistics is included in statistics dump when
@@ -960,6 +961,7 @@ def test_summary_statistics_providers(self):
         self.assertIn("'totalTime':", summary_provider_str)
         self.assertIn("'type': 'python'", summary_provider_str)
 
+    @skipIfWindows
     def test_summary_statistics_providers_vec(self):
         """
         Test summary timing statistics is included in statistics dump when

@Jlalond
Copy link
Contributor Author

Jlalond commented Sep 10, 2024

@Michael137 / @JDevlieghere are we okay disabling these tests for windows? Even on Linux we encountered significant variance between built in types and summary strings. We can either land this or I can make the tests Linux specific and add mac and windows specific tests as a follow up.

@Jlalond Jlalond merged commit 10c04d9 into llvm:main Sep 10, 2024
7 of 8 checks passed
@Jlalond Jlalond deleted the test-stats-windows branch March 7, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants