[SandboxIR] Pass registry #108084
Merged
[SandboxIR] Pass registry #108084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vporpo
requested review from
slackito,
alinas,
tschuett,
aeubanks,
tmsri and
Sterling-Augustine
aeubanks
approved these changes
Sep 10, 2024
aeubanks
reviewed
Sep 10, 2024
| public: | ||
| PassRegistry() = default; | ||
| /// Registers \p PassPtr and takes ownership. | ||
| Pass *registerPass(std::unique_ptr<Pass> &&PassPtr) { |
There was a problem hiding this comment.
maybe this should return a reference instead of a pointer since it'll never be null?
There was a problem hiding this comment.
Yes a reference makes more sense.
aeubanks
reviewed
Sep 10, 2024
| EXPECT_EQ(Registry.getPassByName("test-pass1"), TP1); | ||
| EXPECT_EQ(Registry.getPassByName("test-pass2"), TP2); | ||
|
|
||
| FunctionPassManager FPM("test-fpm"); |
There was a problem hiding this comment.
Yeah we don't really need a pass manager in this test.
This patch implements a simple Pass Registry class, which takes ownership of the passes registered with it and provides an interface to get the pass pointer by its name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a simple Pass Registry class, which takes ownership of the passes registered with it and provides an interface to get the pass pointer by its name.