[Affine] Avoid repeated hash lookups (NFC) #111330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-affine Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/111330.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Affine/Analysis/Utils.cpp b/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
index 194ee9115e3d7a..29608647d85746 100644
--- a/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
+++ b/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
@@ -1927,9 +1927,9 @@ static std::optional<int64_t> getMemoryFootprintBytes(Block &block,
return opInst->emitError("error obtaining memory region\n");
}
- auto it = regions.find(region->memref);
- if (it == regions.end()) {
- regions[region->memref] = std::move(region);
+ auto [it, inserted] = regions.try_emplace(region->memref);
+ if (inserted) {
+ it->second = std::move(region);
} else if (failed(it->second->unionBoundingBox(*region))) {
return opInst->emitWarning(
"getMemoryFootprintBytes: unable to perform a union on a memory "
|
|
@llvm/pr-subscribers-mlir Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/111330.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Affine/Analysis/Utils.cpp b/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
index 194ee9115e3d7a..29608647d85746 100644
--- a/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
+++ b/mlir/lib/Dialect/Affine/Analysis/Utils.cpp
@@ -1927,9 +1927,9 @@ static std::optional<int64_t> getMemoryFootprintBytes(Block &block,
return opInst->emitError("error obtaining memory region\n");
}
- auto it = regions.find(region->memref);
- if (it == regions.end()) {
- regions[region->memref] = std::move(region);
+ auto [it, inserted] = regions.try_emplace(region->memref);
+ if (inserted) {
+ it->second = std::move(region);
} else if (failed(it->second->unionBoundingBox(*region))) {
return opInst->emitWarning(
"getMemoryFootprintBytes: unable to perform a union on a memory "
|
nikic
approved these changes
Oct 7, 2024
| regions[region->memref] = std::move(region); | ||
| auto [it, inserted] = regions.try_emplace(region->memref); | ||
| if (inserted) { | ||
| it->second = std::move(region); |
There was a problem hiding this comment.
Technically you could also do the std::move in try_emplace (because it will only actually get moved if inserted), but it's probably more confusing than this variant...
There was a problem hiding this comment.
Yeah, it's safe but confusing. Personally, when I see std::move, I don't want to see any use until the end of the scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.