Skip to content

[llbd] Finish Turn lldb_private::Status into a value type. (#10616) #112420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2024
Merged

[llbd] Finish Turn lldb_private::Status into a value type. (#10616) #112420

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1732a18
[llbd] Finish Turn lldb_private::Status into a value type. (#10616)
brooksdavis Oct 15, 2024
eacd206
Appease clang-format
brooksdavis Oct 15, 2024
84ae24c
remove accidently inserted tabs
brooksdavis Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,17 +119,15 @@ NativeRegisterContextFreeBSD_arm64::ReadRegister(const RegisterInfo *reg_info,
RegisterValue &reg_value) {
Status error;

if (!reg_info) {
error = Status::FromErrorString("reg_info NULL");
return error;
}
if (!reg_info)
return Status::FromErrorString("reg_info NULL");

const uint32_t reg = reg_info->kinds[lldb::eRegisterKindLLDB];

if (reg == LLDB_INVALID_REGNUM)
return Status("no lldb regnum for %s", reg_info && reg_info->name
? reg_info->name
: "<unknown register>");
return Status::FromErrorStringWithFormat(
"no lldb regnum for %s",
reg_info && reg_info->name ? reg_info->name : "<unknown register>");

uint32_t set = GetRegisterInfo().GetRegisterSetFromRegisterIndex(reg);
error = ReadRegisterSet(set);
Expand All @@ -147,14 +145,14 @@ Status NativeRegisterContextFreeBSD_arm64::WriteRegister(
Status error;

if (!reg_info)
return Status("reg_info NULL");
return Status::FromErrorString("reg_info NULL");

const uint32_t reg = reg_info->kinds[lldb::eRegisterKindLLDB];

if (reg == LLDB_INVALID_REGNUM)
return Status("no lldb regnum for %s", reg_info && reg_info->name
? reg_info->name
: "<unknown register>");
return Status::FromErrorStringWithFormat(
"no lldb regnum for %s",
reg_info && reg_info->name ? reg_info->name : "<unknown register>");

uint32_t set = GetRegisterInfo().GetRegisterSetFromRegisterIndex(reg);
error = ReadRegisterSet(set);
Expand Down
Loading