Skip to content

[ORC_RT][COFF] add more mutex to internal api #112667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yingcong-wu
Copy link
Contributor

Add more mutex to wherever JDStates is used to avoid data race problem.

@sunho
Copy link
Member

sunho commented Oct 17, 2024

Note all the public interface already locks the mutex and the functions changed here are only used within the public interface. So, the lock would be redundant.

@sunho
Copy link
Member

sunho commented Oct 17, 2024

If there is some case I missed, please let me know.

@yingcong-wu
Copy link
Contributor Author

yingcong-wu commented Oct 18, 2024

Note all the public interface already locks the mutex and the functions changed here are only used within the public interface. So, the lock would be redundant.

Okay, good to know that.

@yingcong-wu
Copy link
Contributor Author

I just think that since it is a recursive_mutex, we just need to lock it whenever we use it to avoid the mental burden of remembering to lock it in the public interface.

@yingcong-wu yingcong-wu deleted the yc/1017-orc-coff-add-mutex-usage branch November 13, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants