[reland][libc][bazel] Enable software prefetching for memcpy #113886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will affect only Bazel configuration for now. This is a reland of llvm#108939 which has been reverted because of codegen issues fixed by llvm#113161.
|
@llvm/pr-subscribers-libc Author: Guillaume Chatelet (gchatelet) ChangesThis will affect only Bazel configuration for now. Full diff: https://github.com/llvm/llvm-project/pull/113886.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl b/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl
index f65da9e98226b6..96d7fa86e9ddf2 100644
--- a/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl
+++ b/utils/bazel/llvm-project-overlay/libc/libc_configure_options.bzl
@@ -24,7 +24,7 @@ LIBC_CONFIGURE_OPTIONS = [
# Documentation in libc/src/string/memory_utils/...
# "LIBC_COPT_MEMCPY_USE_EMBEDDED_TINY",
# "LIBC_COPT_MEMCPY_X86_USE_REPMOVSB_FROM_SIZE",
- # "LIBC_COPT_MEMCPY_X86_USE_SOFTWARE_PREFETCHING",
+ "LIBC_COPT_MEMCPY_X86_USE_SOFTWARE_PREFETCHING",
"LIBC_COPT_MEMSET_X86_USE_SOFTWARE_PREFETCHING",
# Documentation in libc/docs/dev/printf_behavior.rst
|
SchrodingerZhu
approved these changes
Oct 28, 2024
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
…3886) This will affect only Bazel configuration for now. This is a reland of llvm#108939 which has been reverted because of codegen issues fixed by llvm#113161.
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 14, 2025
…for memcpy" (#127189) Reverts llvm/llvm-project#113886 We suspect this has caused internal performance regressions, reverting while root causing it more thoroughly.
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
…llvm#127189) Reverts llvm#113886 We suspect this has caused internal performance regressions, reverting while root causing it more thoroughly.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
…llvm#127189) Reverts llvm#113886 We suspect this has caused internal performance regressions, reverting while root causing it more thoroughly.
oneseer
pushed a commit
to oneseer/llvm
that referenced
this pull request
May 24, 2025
… (#127189) Reverts llvm/llvm-project#113886 We suspect this has caused internal performance regressions, reverting while root causing it more thoroughly. patch.cherry: true patch.metadata.original_sha: c65ed96 patch.platforms: chromiumos patch.version_range.from: 554178 patch.version_range.until: 565287 Change-Id: Iaa9fe07e2927d76b37495cb3d0ea6c64633ab50e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will affect only Bazel configuration for now.
This is a reland of #108939 which has been reverted because of codegen
issues fixed by #113161.