Skip to content

[TTI][RISCV] Remove deduplicate type-based VP costing of VPReduction.NFC #117708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2024
Merged

[TTI][RISCV] Remove deduplicate type-based VP costing of VPReduction.NFC #117708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c9317
[TTI][RISCV] Deduplicate type-based VP costing of vpReduction
LiqinWeng Nov 26, 2024
bb33f53
Remove duplicate VPReduction's cost
LiqinWeng Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,37 +1144,6 @@ RISCVTTIImpl::getIntrinsicInstrCost(const IntrinsicCostAttributes &ICA,
: RISCV::VMV_V_X,
LT.second, CostKind);
}
case Intrinsic::vp_reduce_add:
case Intrinsic::vp_reduce_fadd:
case Intrinsic::vp_reduce_mul:
case Intrinsic::vp_reduce_fmul:
case Intrinsic::vp_reduce_and:
case Intrinsic::vp_reduce_or:
case Intrinsic::vp_reduce_xor: {
std::optional<Intrinsic::ID> RedID =
VPIntrinsic::getFunctionalIntrinsicIDForVP(ICA.getID());
assert(RedID.has_value());
unsigned RedOp = getArithmeticReductionInstruction(*RedID);
return getArithmeticReductionCost(RedOp,
cast<VectorType>(ICA.getArgTypes()[1]),
ICA.getFlags(), CostKind);
}
case Intrinsic::vp_reduce_smax:
case Intrinsic::vp_reduce_smin:
case Intrinsic::vp_reduce_umax:
case Intrinsic::vp_reduce_umin:
case Intrinsic::vp_reduce_fmax:
case Intrinsic::vp_reduce_fmaximum:
case Intrinsic::vp_reduce_fmin:
case Intrinsic::vp_reduce_fminimum: {
std::optional<Intrinsic::ID> RedID =
VPIntrinsic::getFunctionalIntrinsicIDForVP(ICA.getID());
assert(RedID.has_value());
Intrinsic::ID MinMaxID = getMinMaxReductionIntrinsicOp(*RedID);
return getMinMaxReductionCost(MinMaxID,
cast<VectorType>(ICA.getArgTypes()[1]),
ICA.getFlags(), CostKind);
}
}

if (ST->hasVInstructions() && RetTy->isVectorTy()) {
Expand Down