Skip to content

AMDGPU: Add codegen support for gfx950 v_ashr_pk_i8/u8_i32 #118304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

AMDGPU: Add codegen support for gfx950 v_ashr_pk_i8/u8_i32 #118304

merged 1 commit into from
Dec 3, 2024

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Dec 2, 2024

Co-authored-by: Sirish Pande Sirish.Pande@amd.com

This was referenced Dec 2, 2024
Merged
Merged
Merged
Merged
Merged
@arsenm arsenm added backend:AMDGPU clang Clang issues not falling into any other category clang:codegen IR generation bugs: mangling, exceptions, etc. clang:frontend Language frontend issues, e.g. anything involving "Sema" llvm:analysis Includes value tracking, cost tables and constant folding llvm:mc Machine (object) code labels Dec 2, 2024 — with Graphite App
This was referenced Dec 2, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@arsenm arsenm mentioned this pull request Dec 2, 2024
Merged
This was referenced Dec 2, 2024
Merged
Merged
Merged
@arsenm arsenm marked this pull request as ready for review December 2, 2024 14:35
This was referenced Dec 2, 2024
Merged
Merged
This was referenced Dec 2, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Dec 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 2, 2024
Merged
Merged
@arsenm arsenm force-pushed the users/arsenm/gfx950/v_cvt_pk_f16_f32 branch from 410d5e1 to 3d3c8e1 Compare December 2, 2024 19:40
@arsenm arsenm force-pushed the users/arsenm/gfx950/v_ashr_pk_i8-patterns branch from 0ed129d to 2c841b7 Compare December 2, 2024 19:40
@arsenm arsenm force-pushed the users/arsenm/gfx950/v_cvt_pk_f16_f32 branch from 3d3c8e1 to f3bd676 Compare December 2, 2024 19:42
@arsenm arsenm force-pushed the users/arsenm/gfx950/v_ashr_pk_i8-patterns branch from 2c841b7 to 6d89898 Compare December 2, 2024 19:42
srpande
srpande approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@srpande srpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. I will add the support in instcombine later.

@arsenm arsenm force-pushed the users/arsenm/gfx950/v_cvt_pk_f16_f32 branch from f3bd676 to a0ec851 Compare December 2, 2024 21:03
@arsenm arsenm force-pushed the users/arsenm/gfx950/v_ashr_pk_i8-patterns branch from 6d89898 to dbf3d5c Compare December 2, 2024 21:03
Base automatically changed from users/arsenm/gfx950/v_cvt_pk_f16_f32 to main December 2, 2024 21:04
@srpande @arsenm
AMDGPU: Add codegen support for gfx950 v_ashr_pk_i8/u8_i32
425ac95 
Co-authored-by: Sirish Pande <Sirish.Pande@amd.com>
@arsenm arsenm force-pushed the users/arsenm/gfx950/v_ashr_pk_i8-patterns branch from dbf3d5c to 425ac95 Compare December 2, 2024 21:05
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Dec 3, 2024 •
edited
Loading

Merge activity

  • Dec 2, 7:21 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 2, 7:23 PM EST: A user merged this pull request with Graphite.

@arsenm arsenm merged commit b80a157 into main Dec 3, 2024
8 checks passed
@arsenm arsenm deleted the users/arsenm/gfx950/v_ashr_pk_i8-patterns branch December 3, 2024 00:23
searlmc1 pushed a commit to ROCm/llvm-project that referenced this pull request Feb 3, 2025
@arsenm @srpande
AMDGPU: Add codegen support for gfx950 v_ashr_pk_i8/u8_i32 (llvm#118304)
0a91079 
Co-authored-by: Sirish Pande <Sirish.Pande@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srpande srpande srpande approved these changes

@jayfoad jayfoad Awaiting requested review from jayfoad

@pravinjagtap pravinjagtap Awaiting requested review from pravinjagtap

@rampitec rampitec Awaiting requested review from rampitec

@shiltian shiltian Awaiting requested review from shiltian

@Sisyph Sisyph Awaiting requested review from Sisyph

Assignees
No one assigned
Labels
backend:AMDGPU clang:codegen IR generation bugs: mangling, exceptions, etc. clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category llvm:analysis Includes value tracking, cost tables and constant folding llvm:mc Machine (object) code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arsenm @llvmbot @srpande