Skip to content

Conversation

RIscRIpt
Copy link
Member

Fix test failure from #119719
84b0f01

Closes #119979

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Dec 14, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 14, 2024

@llvm/pr-subscribers-clang

Author: Richard Dzenis (RIscRIpt)

Changes

Fix test failure from #119719
84b0f01

Closes #119979


Full diff: https://github.com/llvm/llvm-project/pull/119986.diff

1 Files Affected:

  • (modified) clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp (+2-2)
diff --git a/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp b/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
index 066c66884e33c1..7262ffd079a92a 100644
--- a/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
+++ b/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
@@ -18,10 +18,10 @@ int bar() {
 
 struct A {
     int foo() = delete;
-    // CHECK: CXXMethodDecl {{.*}} foo 'int ()' delete
+    // CHECK: CXXMethodDecl {{.*}} foo {{.*}} delete
     // CHECK-NOT: NoBuiltinAttr
     A() = default;
-    // CHECK: CXXConstructorDecl {{.*}} A 'void ()' default
+    // CHECK: CXXConstructorDecl {{.*}} A {{.*}} default
     // CHECK-NOT: NoBuiltinAttr
 };
 

@RIscRIpt
Copy link
Member Author

I reproduced the problem locally by adding -m32 flag to %clang_cl. Changes in this PR fix the test failure.

@RIscRIpt RIscRIpt merged commit 99354f9 into llvm:main Dec 14, 2024
10 checks passed
@RIscRIpt RIscRIpt deleted the x86-msvc-pragma-function-no-builtin-attr branch December 14, 2024 22:18
@RIscRIpt RIscRIpt added test-suite clang:frontend Language frontend issues, e.g. anything involving "Sema" and removed clang Clang issues not falling into any other category labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" test-suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clang :: SemaCXX/msvc-pragma-function-no-builtin-attr.cpp fails on 32-bit x86
2 participants