Boundary condition check hidden under assert #122009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to nominate myself as an additional apple representative (vendor contact) on the llvm security group. I met many of you at the llvm-dev meeting roundtable(s) in Santa Clara. I closely work with @ahmedbougacha @jloerofs at apple.
When assert() are disabled, this function can return corrupt data.
|
@llvm/pr-subscribers-debuginfo Author: Abhay Kanhere (AbhayKanhere) Changesif asserts are disabled this code can return corrupted memory Full diff: https://github.com/llvm/llvm-project/pull/122009.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp b/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp
index a5e6bebcd29c7f..6306476fac657f 100644
--- a/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp
+++ b/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp
@@ -997,13 +997,6 @@ class VarLocBasedLDV : public LDVImpl {
return *VLS;
}
- const VarLocSet &getVarLocsInMBB(const MachineBasicBlock *MBB,
- const VarLocInMBB &Locs) const {
- auto It = Locs.find(MBB);
- assert(It != Locs.end() && "MBB not in map");
- return *It->second;
- }
-
/// Tests whether this instruction is a spill to a stack location.
bool isSpillInstruction(const MachineInstr &MI, MachineFunction *MF);
@@ -1286,7 +1279,10 @@ void VarLocBasedLDV::printVarLocInMBB(const MachineFunction &MF,
for (const MachineBasicBlock &BB : MF) {
if (!V.count(&BB))
continue;
- const VarLocSet &L = getVarLocsInMBB(&BB, V);
+ auto It = V.find(&BB);
+ if (It == V.end())
+ continue;
+ const VarLocSet &L = *It->second;
if (L.empty())
continue;
SmallVector<VarLoc, 32> VarLocs;
|
|
fixing merge nodes. discard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if asserts are disabled this code can return corrupted memory