Skip to content

Conversation

mstorsjo
Copy link
Member

Ignore this PR, it's only opened for test running code through the PR test pipeline.

@mstorsjo mstorsjo requested a review from a team as a code owner January 20, 2025 09:00
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 20, 2025
@mstorsjo mstorsjo marked this pull request as draft January 20, 2025 09:00
@llvmbot
Copy link
Member

llvmbot commented Jan 20, 2025

@llvm/pr-subscribers-libcxx

Author: Martin Storsjö (mstorsjo)

Changes

Ignore this PR, it's only opened for test running code through the PR test pipeline.


Full diff: https://github.com/llvm/llvm-project/pull/123570.diff

2 Files Affected:

  • (modified) libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp (-5)
  • (modified) libcxx/utils/ci/run-buildbot (+6-6)
diff --git a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
index 6ffe750564c2c9..5afd4465db31e0 100644
--- a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
+++ b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
@@ -28,11 +28,6 @@
 //
 // XFAIL: target=powerpc-{{.+}}-aix{{.*}}
 
-// By default, off_t is typically a 32-bit integer on ARMv7 Linux systems,
-// meaning it can represent file sizes up to 2GB (2^31 bytes) only.
-//
-// UNSUPPORTED: target=armv7-unknown-linux-gnueabihf
-
 #include <fstream>
 #include <iostream>
 #include <cassert>
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index f1ede6474eb9ee..ec3dcdb8628a31 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -136,7 +136,7 @@ function generate-cmake-base() {
           -DLIBCXX_ENABLE_WERROR=YES \
           -DLIBCXXABI_ENABLE_WERROR=YES \
           -DLIBUNWIND_ENABLE_WERROR=YES \
-          -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+          -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
           "${@}"
 }
 
@@ -391,7 +391,7 @@ bootstrapping-build)
           -DLLVM_TARGETS_TO_BUILD="host" \
           -DRUNTIMES_BUILD_ALLOW_DARWIN=ON \
           -DLLVM_ENABLE_ASSERTIONS=ON \
-          -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
+          -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
 
     step "Running the libc++ and libc++abi tests"
     ${NINJA} -vC "${BUILD_DIR}" check-runtimes
@@ -564,7 +564,7 @@ apple-system-hardened)
         -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
         -DCMAKE_BUILD_TYPE=RelWithDebInfo \
         -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}/cxx" \
-        -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+        -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
         -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
         -DLIBCXX_CXX_ABI=libcxxabi \
         -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Apple.cmake" \
@@ -580,7 +580,7 @@ apple-system-hardened)
         -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
         -DCMAKE_BUILD_TYPE=RelWithDebInfo \
         -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}/unwind" \
-        -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+        -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
         -DLLVM_ENABLE_RUNTIMES="libunwind" \
         -DLIBUNWIND_TEST_CONFIG="apple-libunwind-system.cfg.in" \
         -DLIBUNWIND_TEST_PARAMS="${params}" \
@@ -610,7 +610,7 @@ apple-system)
         -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
         -DCMAKE_BUILD_TYPE=RelWithDebInfo \
         -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}/cxx" \
-        -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+        -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
         -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
         -DLIBCXX_CXX_ABI=libcxxabi \
         -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Apple.cmake" \
@@ -626,7 +626,7 @@ apple-system)
         -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
         -DCMAKE_BUILD_TYPE=RelWithDebInfo \
         -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}/unwind" \
-        -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
+        -DLLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
         -DLLVM_ENABLE_RUNTIMES="libunwind" \
         -DLIBUNWIND_TEST_CONFIG="apple-libunwind-system.cfg.in" \
         -DLIBUNWIND_TEST_PARAMS="${params}" \

Copy link

github-actions bot commented Apr 7, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

mstorsjo added 2 commits April 9, 2025 11:17
This test currently hardcodes which environments have got 80 bit
long doubles on x86_64; add a check for the actual size of
the long doubles as well.

This allows waiving this part of the test, if we have x86_64
setups in any of these environments, configured for a nonstandard
size of long doubles.
@ldionne ldionne closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants