[libc][float_dec_converter_limited] Add missing LIBC_INLINE #125655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused a build failure in check-libc introduced by commit b53da77.
|
@llvm/pr-subscribers-libc Author: Simon Tatham (statham-arm) ChangesThis caused a build failure in check-libc introduced by commit b53da77. Full diff: https://github.com/llvm/llvm-project/pull/125655.diff 1 Files Affected:
diff --git a/libc/src/stdio/printf_core/float_dec_converter_limited.h b/libc/src/stdio/printf_core/float_dec_converter_limited.h
index 22803884526e25..a98e6cdaa0db7e 100644
--- a/libc/src/stdio/printf_core/float_dec_converter_limited.h
+++ b/libc/src/stdio/printf_core/float_dec_converter_limited.h
@@ -112,7 +112,7 @@ struct DigitsOutput {
// 1292913986/2^32. That is a rounded-down approximation to log10(2), accurate
// enough that for any binary exponent in the range of float128 it will give
// the correct value of floor(log10(2^n)).
-int estimate_log10(int exponent_of_2) {
+LIBC_INLINE int estimate_log10(int exponent_of_2) {
return (exponent_of_2 * 1292913986LL) >> 32;
}
|
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
) This caused a build failure in check-libc introduced by commit b53da77.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a build failure in check-libc introduced by commit b53da77.