-
Notifications
You must be signed in to change notification settings - Fork 14k
[flang][rt] Add decimal files to device runtime #126778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-flang-runtime Author: Valentin Clement (バレンタイン クレメン) (clementval) ChangesThe library FortranDecimal is not used anymore with the runtime but its files are now integrated. Add the files for the device build as well. Full diff: https://github.com/llvm/llvm-project/pull/126778.diff 1 Files Affected:
diff --git a/flang/runtime/CMakeLists.txt b/flang/runtime/CMakeLists.txt
index 7cc720e2df9af..f651ea83664eb 100644
--- a/flang/runtime/CMakeLists.txt
+++ b/flang/runtime/CMakeLists.txt
@@ -189,6 +189,8 @@ include(AddFlangOffloadRuntime)
# List of files that are buildable for all devices.
set(supported_files
+ ${FLANG_SOURCE_DIR}/lib/Decimal/binary-to-decimal.cpp
+ ${FLANG_SOURCE_DIR}/lib/Decimal/decimal-to-binary.cpp
ISO_Fortran_binding.cpp
allocatable.cpp
allocator-registry.cpp
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/22571 Here is the relevant piece of the build log for the reference
|
The library FortranDecimal is not used anymore with the runtime but its files are now integrated. Add the files for the device build as well.
The library FortranDecimal is not used anymore with the runtime but its files are now integrated. Add the files for the device build as well.
The library FortranDecimal is not used anymore with the runtime but its files are now integrated. Add the files for the device build as well.
The library FortranDecimal is not used anymore with the runtime but its files are now integrated. Add the files for the device build as well.
The library FortranDecimal is not used anymore with the runtime but its files are now integrated. Add the files for the device build as well.