Skip to content

[clang][bytecode] Always reject ctors of invalid parent decls #128295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2025
Merged

[clang][bytecode] Always reject ctors of invalid parent decls #128295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/lib/AST/ByteCode/Interp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,8 +1238,10 @@ static bool checkConstructor(InterpState &S, CodePtr OpPC, const Function *Func,
const Pointer &ThisPtr) {
assert(Func->isConstructor());

const Descriptor *D = ThisPtr.getFieldDesc();
if (Func->getParentDecl()->isInvalidDecl())
return false;

const Descriptor *D = ThisPtr.getFieldDesc();
// FIXME: I think this case is not 100% correct. E.g. a pointer into a
// subobject of a composite array.
if (!D->ElemRecord)
Expand Down
8 changes: 8 additions & 0 deletions clang/test/AST/ByteCode/records.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1738,4 +1738,12 @@ namespace DeadUpcast {
namespace CtorOfInvalidClass {
constexpr struct { Unknown U; } InvalidCtor; // both-error {{unknown type name 'Unknown'}} \
// both-error {{must be initialized by a constant expression}}

#if __cplusplus >= 202002L
template <typename T, auto Q>
concept ReferenceOf = Q;
/// This calls a valid and constexpr copy constructor of InvalidCtor,
/// but should still be rejected.
template<ReferenceOf<InvalidCtor> auto R, typename Rep> int F; // both-error {{non-type template argument is not a constant expression}}
#endif
}
Loading