[emacs] Check for a 'buffer' type instead of 'buffer-live' #128385
Conversation
This is a follow-up to commit f69110d ("Check for a 'buffer' type instead of 'buffer-live'."). In Emacs 29, 'buffer-live' is no longer recognized as a type and generates a compilation warning. Every function that requires a live buffer already checks whether the buffer is live, so we don't need to check ourselves.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-clang-tools-extra Author: Roi Martin (jroimartin) ChangesThis is a follow-up to commit f69110d ("Check for a 'buffer' type instead of 'buffer-live'."). In Emacs 29, 'buffer-live' is no longer recognized as a type and generates a compilation warning. Every function that requires a live buffer already checks whether the buffer is live, so we don't need to check ourselves. Full diff: https://github.com/llvm/llvm-project/pull/128385.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.el b/clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.el
index f3a949f8c1b55..1cb9a0340b5e3 100644
--- a/clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.el
+++ b/clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.el
@@ -249,7 +249,7 @@ Add a missing header if there is any. If there are multiple
possible headers the user can select one of them to be included.
Temporarily highlight the affected symbols. Asynchronously call
clang-include-fixer to insert the selected header."
- (cl-check-type stdout buffer-live)
+ (cl-check-type stdout buffer)
(let ((context (clang-include-fixer--parse-json stdout)))
(let-alist context
(cond
|
|
Ping |
This is a follow-up to commit f69110d ("Check for a 'buffer' type instead of 'buffer-live'.").
In Emacs 29, 'buffer-live' is no longer recognized as a type and generates a compilation warning. Every function that requires a live buffer already checks whether the buffer is live, so we don't need to check ourselves.