[clang-tidy] misc-unused-using-decls: add correct handling of operator"" with template parametes
#129392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang-tidy Author: Baranov Victor (vbvictor) ChangesFixes false-positives when operator"" has template paremetes, e.g. template <char... Ts>
int operator""_r() {
return {};
}Full diff: https://github.com/llvm/llvm-project/pull/129392.diff 3 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp b/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp
index 5d74907aa9fab..0b501b9c9d6a3 100644
--- a/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp
@@ -184,8 +184,16 @@ void UnusedUsingDeclsCheck::check(const MatchFinder::MatchResult &Result) {
return;
}
// Check user-defined literals
- if (const auto *UDL = Result.Nodes.getNodeAs<UserDefinedLiteral>("used"))
- removeFromFoundDecls(UDL->getCalleeDecl());
+ if (const auto *UDL = Result.Nodes.getNodeAs<UserDefinedLiteral>("used")) {
+ const Decl *CalleeDecl = UDL->getCalleeDecl();
+ if (const auto *FD = dyn_cast<FunctionDecl>(UDL->getCalleeDecl())) {
+ if (const FunctionTemplateDecl *FPT = FD->getPrimaryTemplate()) {
+ removeFromFoundDecls(FPT);
+ return;
+ }
+ }
+ removeFromFoundDecls(CalleeDecl);
+ }
}
void UnusedUsingDeclsCheck::removeFromFoundDecls(const Decl *D) {
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index 07a79d6bbe807..ccdb741ef5879 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -137,6 +137,10 @@ Changes in existing checks
<clang-tidy/checks/performance/move-const-arg>` check by fixing false negatives
on ternary operators calling ``std::move``.
+- Improved :doc:`misc-unused-using-decls
+ <clang-tidy/checks/misc/unused-using-decls>` check by fixing false positives
+ on ``operator""`` with template parameters.
+
Removed checks
^^^^^^^^^^^^^^
diff --git a/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp b/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp
index 12fc18f340f21..62aa17b0b1c22 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp
@@ -222,3 +222,19 @@ using gh69714::StructGH69714_1;
using gh69714::StructGH69714_2;
struct StructGH69714_1 a;
struct StructGH69714_2 *b;
+
+namespace gh53444 {
+namespace my_literals {
+ template <char... Ts>
+ int operator""_r() {
+ return {};
+ }
+}
+
+using my_literals::operator"" _r;
+
+int foo() {
+ auto x2 = 123_r;
+}
+
+}
|
|
@llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) ChangesFixes false-positives when operator"" has template paremetes, e.g. template <char... Ts>
int operator""_r() {
return {};
}Full diff: https://github.com/llvm/llvm-project/pull/129392.diff 3 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp b/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp
index 5d74907aa9fab..0b501b9c9d6a3 100644
--- a/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp
@@ -184,8 +184,16 @@ void UnusedUsingDeclsCheck::check(const MatchFinder::MatchResult &Result) {
return;
}
// Check user-defined literals
- if (const auto *UDL = Result.Nodes.getNodeAs<UserDefinedLiteral>("used"))
- removeFromFoundDecls(UDL->getCalleeDecl());
+ if (const auto *UDL = Result.Nodes.getNodeAs<UserDefinedLiteral>("used")) {
+ const Decl *CalleeDecl = UDL->getCalleeDecl();
+ if (const auto *FD = dyn_cast<FunctionDecl>(UDL->getCalleeDecl())) {
+ if (const FunctionTemplateDecl *FPT = FD->getPrimaryTemplate()) {
+ removeFromFoundDecls(FPT);
+ return;
+ }
+ }
+ removeFromFoundDecls(CalleeDecl);
+ }
}
void UnusedUsingDeclsCheck::removeFromFoundDecls(const Decl *D) {
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index 07a79d6bbe807..ccdb741ef5879 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -137,6 +137,10 @@ Changes in existing checks
<clang-tidy/checks/performance/move-const-arg>` check by fixing false negatives
on ternary operators calling ``std::move``.
+- Improved :doc:`misc-unused-using-decls
+ <clang-tidy/checks/misc/unused-using-decls>` check by fixing false positives
+ on ``operator""`` with template parameters.
+
Removed checks
^^^^^^^^^^^^^^
diff --git a/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp b/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp
index 12fc18f340f21..62aa17b0b1c22 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/misc/unused-using-decls.cpp
@@ -222,3 +222,19 @@ using gh69714::StructGH69714_1;
using gh69714::StructGH69714_2;
struct StructGH69714_1 a;
struct StructGH69714_2 *b;
+
+namespace gh53444 {
+namespace my_literals {
+ template <char... Ts>
+ int operator""_r() {
+ return {};
+ }
+}
+
+using my_literals::operator"" _r;
+
+int foo() {
+ auto x2 = 123_r;
+}
+
+}
|
vbvictor
changed the title
misc-unused-using-decls: add correct handling of operator"" with template parametesmisc-unused-using-decls: add correct handling of operator"" with template parametes
HerrCai0907
reviewed
Mar 2, 2025
Co-authored-by: Congcong Cai <congcongcai0907@163.com>
|
@HerrCai0907 Could you please merge this PR, thank you. |
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
…ator""` with template parametes (llvm#129392) Fixes false-positives when operator"" has template paremetes, e.g. ```cpp template <char... Ts> int operator""_r() { return {}; } ``` Closes llvm#53444. --------- Co-authored-by: Congcong Cai <congcongcai0907@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false-positives when operator"" has template paremetes, e.g.
Closes #53444.