Skip to content

[libclc] Skip opt command if opt_flags is empty #130882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[libclc] Skip opt command if opt_flags is empty #130882

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1727cb4
[libclc] Skip opt command if opt_flags is empty
wenju-he Mar 12, 2025
d3543f3
unconditionally add builtins_opt_lib_tgt, which is empty if OPT_FLAGS…
wenju-he Mar 18, 2025
e02feed
update comment
wenju-he Mar 18, 2025
cb61d08
refine
wenju-he Mar 18, 2025
e7cecc2
unify PROPERTIES FOLDER
wenju-he Mar 18, 2025
36ea924
NOT ARG_OPT_FLAGS
wenju-he Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions libclc/cmake/modules/AddLibclc.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,22 +342,32 @@ function(add_libclc_builtin_set)

set( builtins_opt_lib_tgt builtins.opt.${ARG_ARCH_SUFFIX} )

# Add opt target
add_custom_command( OUTPUT ${builtins_opt_lib_tgt}.bc
COMMAND ${opt_exe} ${ARG_OPT_FLAGS} -o ${builtins_opt_lib_tgt}.bc
${builtins_link_lib}
DEPENDS ${opt_target} ${builtins_link_lib} ${builtins_link_lib_tgt}
)
add_custom_target( ${builtins_opt_lib_tgt}
ALL DEPENDS ${builtins_opt_lib_tgt}.bc
)
if( NOT ARG_OPT_FLAGS )
# Add empty opt target.
add_custom_target( ${builtins_opt_lib_tgt} ALL )
add_dependencies( ${builtins_opt_lib_tgt} ${builtins_link_lib_tgt} )

set( builtins_opt_lib ${builtins_link_lib} )
else()
# Add opt target
add_custom_command( OUTPUT ${builtins_opt_lib_tgt}.bc
COMMAND ${opt_exe} ${ARG_OPT_FLAGS} -o ${builtins_opt_lib_tgt}.bc
${builtins_link_lib}
DEPENDS ${opt_target} ${builtins_link_lib} ${builtins_link_lib_tgt}
)
add_custom_target( ${builtins_opt_lib_tgt}
ALL DEPENDS ${builtins_opt_lib_tgt}.bc
)
set_target_properties( ${builtins_opt_lib_tgt} PROPERTIES
TARGET_FILE ${CMAKE_CURRENT_BINARY_DIR}/${builtins_opt_lib_tgt}.bc
)

set( builtins_opt_lib $<TARGET_PROPERTY:${builtins_opt_lib_tgt},TARGET_FILE> )
endif()
set_target_properties( ${builtins_opt_lib_tgt} PROPERTIES
TARGET_FILE ${CMAKE_CURRENT_BINARY_DIR}/${builtins_opt_lib_tgt}.bc
FOLDER "libclc/Device IR/Opt"
)

set( builtins_opt_lib $<TARGET_PROPERTY:${builtins_opt_lib_tgt},TARGET_FILE> )

# Add prepare target
set( obj_suffix ${ARG_ARCH_SUFFIX}.bc )
add_custom_command( OUTPUT ${obj_suffix}
Expand Down