Skip to content

[Basic] Use SmallSet::insert_range (NFC) #133594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@kazutakahirata kazutakahirata requested a review from kuhar March 29, 2025 19:36
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Mar 29, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 29, 2025

@llvm/pr-subscribers-clang

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/133594.diff

1 Files Affected:

  • (modified) clang/include/clang/Basic/TargetInfo.h (+1-2)
diff --git a/clang/include/clang/Basic/TargetInfo.h b/clang/include/clang/Basic/TargetInfo.h
index 497d68779b92b..93cffe84e2f42 100644
--- a/clang/include/clang/Basic/TargetInfo.h
+++ b/clang/include/clang/Basic/TargetInfo.h
@@ -1175,8 +1175,7 @@ class TargetInfo : public TransferrableTargetInfo,
     }
     void setRequiresImmediate(llvm::ArrayRef<int> Exacts) {
       Flags |= CI_ImmediateConstant;
-      for (int Exact : Exacts)
-        ImmSet.insert(Exact);
+      ImmSet.insert_range(Exacts);
     }
     void setRequiresImmediate(int Exact) {
       Flags |= CI_ImmediateConstant;

@kazutakahirata kazutakahirata merged commit 3d43739 into llvm:main Mar 29, 2025
14 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_set_range_clang branch March 29, 2025 21:26
@llvm-ci
Copy link
Collaborator

llvm-ci commented Mar 29, 2025

LLVM Buildbot has detected a new failure on builder lldb-arm-ubuntu running on linaro-lldb-arm-ubuntu while building clang at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/13707

Here is the relevant piece of the build log for the reference
Step 6 (test) failure: build (failure)
...
PASS: lldb-unit :: Language/CPlusPlus/./LanguageCPlusPlusTests/1/6 (2153 of 2932)
PASS: lldb-unit :: Language/CPlusPlus/./LanguageCPlusPlusTests/2/6 (2154 of 2932)
PASS: lldb-unit :: Language/CPlusPlus/./LanguageCPlusPlusTests/3/6 (2155 of 2932)
PASS: lldb-unit :: Language/CPlusPlus/./LanguageCPlusPlusTests/4/6 (2156 of 2932)
PASS: lldb-unit :: Language/CPlusPlus/./LanguageCPlusPlusTests/5/6 (2157 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/0/29 (2158 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/1/29 (2159 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/10/29 (2160 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/11/29 (2161 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/12/29 (2162 of 2932)
FAIL: lldb-unit :: Host/./HostTests/33/96 (2163 of 2932)
******************** TEST 'lldb-unit :: Host/./HostTests/33/96' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/unittests/Host/./HostTests-lldb-unit-1310901-33-96.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=96 GTEST_SHARD_INDEX=33 /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/unittests/Host/./HostTests
--

Script:
--
/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/unittests/Host/./HostTests --gtest_filter=MainLoopTest.CallbackWithTimeout
--
../llvm-project/lldb/unittests/Host/MainLoopTest.cpp:227: Failure
Expected: (std::chrono::steady_clock::now() - start) >= (std::chrono::seconds(2)), actual: 8-byte object <91-1A 35-77 00-00 00-00> vs 8-byte object <02-00 00-00 00-00 00-00>


../llvm-project/lldb/unittests/Host/MainLoopTest.cpp:227
Expected: (std::chrono::steady_clock::now() - start) >= (std::chrono::seconds(2)), actual: 8-byte object <91-1A 35-77 00-00 00-00> vs 8-byte object <02-00 00-00 00-00 00-00>



********************
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/13/29 (2164 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/14/29 (2165 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/15/29 (2166 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/16/29 (2167 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/17/29 (2168 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/18/29 (2169 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/19/29 (2170 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/21/29 (2171 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/2/29 (2172 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/20/29 (2173 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/22/29 (2174 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/23/29 (2175 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/24/29 (2176 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/25/29 (2177 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/26/29 (2178 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/27/29 (2179 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/28/29 (2180 of 2932)
PASS: lldb-unit :: Language/Highlighting/./HighlighterTests/3/29 (2181 of 2932)

@llvm-ci
Copy link
Collaborator

llvm-ci commented Mar 29, 2025

LLVM Buildbot has detected a new failure on builder lldb-aarch64-ubuntu running on linaro-lldb-aarch64-ubuntu while building clang at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15138

Here is the relevant piece of the build log for the reference
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: lang/cpp/stl/TestSTL.py (864 of 2112)
XFAIL: lldb-api :: lang/cpp/trivial_abi/TestTrivialABI.py (865 of 2112)
PASS: lldb-api :: lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py (866 of 2112)
PASS: lldb-api :: lang/cpp/type_lookup/TestCppTypeLookup.py (867 of 2112)
PASS: lldb-api :: lang/cpp/typedef-to-outer-fwd/TestTypedefToOuterFwd.py (868 of 2112)
PASS: lldb-api :: lang/cpp/typeof/TestTypeOfDeclTypeExpr.py (869 of 2112)
PASS: lldb-api :: lang/cpp/thunk/TestThunk.py (870 of 2112)
PASS: lldb-api :: lang/cpp/typedef/TestCppTypedef.py (871 of 2112)
PASS: lldb-api :: lang/cpp/template/TestTemplateArgs.py (872 of 2112)
PASS: lldb-api :: lang/cpp/unsigned_types/TestUnsignedTypes.py (873 of 2112)
FAIL: lldb-api :: lang/cpp/unique-types/TestUniqueTypes.py (874 of 2112)
******************** TEST 'lldb-api :: lang/cpp/unique-types/TestUniqueTypes.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --arch aarch64 --build-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/lang/cpp/unique-types -p TestUniqueTypes.py
--
Exit Code: -11

Command Output (stdout):
--
lldb version 21.0.0git (https://github.com/llvm/llvm-project.git revision 3d43739753f3b50824a09343efe40a2a476488df)
  clang revision 3d43739753f3b50824a09343efe40a2a476488df
  llvm revision 3d43739753f3b50824a09343efe40a2a476488df
Skipping the following test categories: ['libc++', 'dsym', 'gmodules', 'debugserver', 'objc']

--
Command Output (stderr):
--
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_dsym (TestUniqueTypes.UniqueTypesTestCase) (test case does not fall in any category of interest for this run) 
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_dwarf (TestUniqueTypes.UniqueTypesTestCase)
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_dwo (TestUniqueTypes.UniqueTypesTestCase)
----------------------------------------------------------------------
Ran 3 tests in 1.006s

OK (skipped=1)

--

********************
PASS: lldb-api :: lang/cpp/unique-types2/TestUniqueTypes2.py (875 of 2112)
PASS: lldb-api :: lang/cpp/unique-types4/TestUniqueTypes4.py (876 of 2112)
PASS: lldb-api :: lang/cpp/unique-types3/TestUniqueTypes3.py (877 of 2112)
PASS: lldb-api :: lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py (878 of 2112)
PASS: lldb-api :: lang/cpp/unicode-literals/TestUnicodeLiterals.py (879 of 2112)
PASS: lldb-api :: lang/cpp/virtual-overload/TestVirtualOverload.py (880 of 2112)
PASS: lldb-api :: lang/cpp/wchar_t/TestCxxWCharT.py (881 of 2112)
UNSUPPORTED: lldb-api :: lang/objc/bitfield_ivars/TestBitfieldIvars.py (882 of 2112)
UNSUPPORTED: lldb-api :: lang/objc/blocks/TestObjCIvarsInBlocks.py (883 of 2112)
UNSUPPORTED: lldb-api :: lang/objc/charstar_dyntype/TestCharStarDynType.py (884 of 2112)

@llvm-ci
Copy link
Collaborator

llvm-ci commented Mar 29, 2025

LLVM Buildbot has detected a new failure on builder clang-aarch64-sve2-vla-2stage running on linaro-g4-02 while building clang at step 12 "ninja check 2".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/199/builds/2460

Here is the relevant piece of the build log for the reference
Step 12 (ninja check 2) failure: stage 2 checked (failure)
...
PASS: Flang :: Driver/print-resource-dir.F90 (24739 of 96438)
PASS: Flang :: Driver/parse-error.ll (24740 of 96438)
PASS: Flang :: Driver/predefined-macros-compiler-version.F90 (24741 of 96438)
PASS: Flang :: Driver/print-effective-triple.f90 (24742 of 96438)
PASS: Clangd Unit Tests :: ./ClangdTests/78/81 (24743 of 96438)
PASS: Flang :: Driver/phases.f90 (24744 of 96438)
PASS: Flang :: Driver/override-triple.ll (24745 of 96438)
PASS: Flang :: Driver/parse-fir-error.ll (24746 of 96438)
PASS: Flang :: Driver/missing-arg.f90 (24747 of 96438)
UNRESOLVED: Flang :: Driver/slp-vectorize.ll (24748 of 96438)
******************** TEST 'Flang :: Driver/slp-vectorize.ll' FAILED ********************
Test has no 'RUN:' line
********************
PASS: Flang :: Driver/mlir-pass-pipeline.f90 (24749 of 96438)
PASS: Flang :: Driver/print-target-triple.f90 (24750 of 96438)
PASS: Flang :: Driver/print-pipeline-passes.f90 (24751 of 96438)
PASS: Flang :: Driver/parse-ir-error.f95 (24752 of 96438)
PASS: Flang :: Driver/include-header.f90 (24753 of 96438)
PASS: Flang :: Driver/pthread.f90 (24754 of 96438)
PASS: Flang :: Driver/mlink-builtin-bc.f90 (24755 of 96438)
PASS: Flang :: Driver/pp-fixed-form.f90 (24756 of 96438)
PASS: Flang :: Driver/pass-plugin-not-found.f90 (24757 of 96438)
PASS: Flang :: Driver/std2018-wrong.f90 (24758 of 96438)
PASS: Flang :: Driver/lto-bc.f90 (24759 of 96438)
PASS: Flang :: Driver/supported-suffices/f03-suffix.f03 (24760 of 96438)
PASS: Flang :: Driver/supported-suffices/f08-suffix.f08 (24761 of 96438)
PASS: Flang :: Driver/fixed-line-length.f90 (24762 of 96438)
PASS: Flang :: Driver/scanning-error.f95 (24763 of 96438)
PASS: Flang :: Driver/target-gpu-features.f90 (24764 of 96438)
PASS: Flang :: Driver/multiple-input-files.f90 (24765 of 96438)
PASS: Flang :: Driver/q-unused-arguments.f90 (24766 of 96438)
PASS: Flang :: Driver/target.f90 (24767 of 96438)
PASS: Flang :: Driver/tco-code-gen-llvm.fir (24768 of 96438)
PASS: Flang :: Driver/fsave-optimization-record.f90 (24769 of 96438)
PASS: Flang :: Driver/no-duplicate-main.f90 (24770 of 96438)
PASS: Flang :: Driver/mllvm.f90 (24771 of 96438)
PASS: Flang :: Driver/unsupported-vscale-max-min.f90 (24772 of 96438)
PASS: Flang :: Driver/input-from-stdin/input-from-stdin.f90 (24773 of 96438)
PASS: Flang :: Driver/unparse-with-modules.f90 (24774 of 96438)
PASS: Flang :: Driver/lto-flags.f90 (24775 of 96438)
PASS: Flang :: Driver/falias-analysis.f90 (24776 of 96438)
PASS: Flang :: Driver/target-machine-error.f90 (24777 of 96438)
PASS: Flang :: Driver/unparse-use-analyzed.f95 (24778 of 96438)
PASS: Flang :: Driver/std2018.f90 (24779 of 96438)
PASS: Flang :: Driver/optimization-remark-invalid.f90 (24780 of 96438)
PASS: Flang :: Driver/optimization-remark-backend.f90 (24781 of 96438)
PASS: Flang :: Driver/save-temps-use-module.f90 (24782 of 96438)
PASS: Flang :: Driver/prescanner-diag.f90 (24783 of 96438)
PASS: Flang :: Driver/save-temps.f90 (24784 of 96438)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants